Add maven.compiler.failOnWarning to gerrit jobs

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

Add maven.compiler.failOnWarning to gerrit jobs

Roland Grunberg
Tycho 1.5.0 (under development, in eclipse parent pom) has support for
maven.compiler.failOnWarning [1] . This would fail the build on
compiler warnings and make it very clear to contributors/reviewers when
changes introduce such issues.

It would be great to enable this property in JDT gerrit builds. Is
there any opposition to this, or to enabling it in any particular
gerrit job ?

Cheers,
--
Roland Grunberg

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=547470

_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: Add maven.compiler.failOnWarning to gerrit jobs

Daniel Megert
Hi Roland

Did you check whether the JDT jobs currently are warning free? If not, this would block unrelated/new Gerrit changes.

Dani



From:        Roland Grunberg <[hidden email]>
To:        "Eclipse JDT general developers list." <[hidden email]>
Date:        24.09.2019 16:56
Subject:        [EXTERNAL] [jdt-dev] Add maven.compiler.failOnWarning to gerrit jobs
Sent by:        [hidden email]




Tycho 1.5.0 (under development, in eclipse parent pom) has support for
maven.compiler.failOnWarning [1] . This would fail the build on
compiler warnings and make it very clear to contributors/reviewers when
changes introduce such issues.

It would be great to enable this property in JDT gerrit builds. Is
there any opposition to this, or to enabling it in any particular
gerrit job ?

Cheers,
--
Roland Grunberg

[1]
https://bugs.eclipse.org/bugs/show_bug.cgi?id=547470

_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev





_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: Add maven.compiler.failOnWarning to gerrit jobs

Roland Grunberg
On Tue, 2019-09-24 at 17:22 +0200, Daniel Megert wrote:
> Hi Roland
> Did you check whether the JDT jobs currently are warning free? If not, this would block unrelated/new Gerrit changes.

I checked jdt.ui which passed so that should be the first one we try.

jdt.debug already has some existing warnings that need to be fixed (or
suppressed), and it appears that jdt.core is overriding cbi-ecj-version
(with an older version) so the feature is not available there. If I use
latest ecj from eclipse-parent, jdt.core would also appear to fail on
some other warnings further down.

--
Roland Grunberg

_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: Add maven.compiler.failOnWarning to gerrit jobs

Daniel Megert
Where did you see the warning for JDT Debug? Looking at https://ci.eclipse.org/jdt/job/eclipse.jdt.debug-Gerrit/888/seems to be free of warnings.

Dani



From:        Roland Grunberg <[hidden email]>
To:        "Eclipse JDT general developers list." <[hidden email]>
Date:        24.09.2019 17:44
Subject:        [EXTERNAL] Re: [jdt-dev] Add maven.compiler.failOnWarning to gerrit jobs
Sent by:        [hidden email]




On Tue, 2019-09-24 at 17:22 +0200, Daniel Megert wrote:
> Hi Roland
> Did you check whether the JDT jobs currently are warning free? If not, this would block unrelated/new Gerrit changes.

I checked jdt.ui which passed so that should be the first one we try.

jdt.debug already has some existing warnings that need to be fixed (or
suppressed), and it appears that jdt.core is overriding cbi-ecj-version
(with an older version) so the feature is not available there. If I use
latest ecj from eclipse-parent, jdt.core would also appear to fail on
some other warnings further down.

--
Roland Grunberg

_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev





_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: Add maven.compiler.failOnWarning to gerrit jobs

Roland Grunberg
On Tue, 2019-09-24 at 17:49 +0200, Daniel Megert wrote:
> Where did you see the warning for JDT Debug? Looking at https://ci.eclipse.org/jdt/job/eclipse.jdt.debug-Gerrit/888/seems to be free of warnings.

I'm seeing :

[INFO] --- tycho-compiler-plugin:1.5.0-SNAPSHOT:compile (default-compile) @ org.eclipse.jdt.debug ---
[INFO] Compiling 121 source files to /notnfs/git/eclipse.jdt.debug/org.eclipse.jdt.debug/target/jdi.jar-classes
[INFO] Compiling 352 source files to /notnfs/git/eclipse.jdt.debug/org.eclipse.jdt.debug/target/jdimodel.jar-classes
[WARNING] /notnfs/git/eclipse.jdt.debug/org.eclipse.jdt.debug/model/org/eclipse/jdt/internal/debug/core/hcr/JavaHotCodeReplaceManager.java:[72]
    import org.eclipse.jdt.internal.core.util.Util;
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Discouraged access: The type 'Util' is not API (restriction on classpath entry '/notnfs/tmp/m2/p2/osgi/bundle/org.eclipse.jdt.core/3.20.0.v20190923-1401/org.eclipse.jdt.core-3.20.0.v20190923-1401.jar')
[WARNING] /notnfs/git/eclipse.jdt.debug/org.eclipse.jdt.debug/model/org/eclipse/jdt/internal/debug/core/hcr/JavaHotCodeReplaceManager.java:[711]
    bytes = Util.getResourceContentsAsByteArray((IFile) resource);
            ^^^^
Discouraged access: The type 'Util' is not API (restriction on classpath entry '/notnfs/tmp/m2/p2/osgi/bundle/org.eclipse.jdt.core/3.20.0.v20190923-1401/org.eclipse.jdt.core-3.20.0.v20190923-1401.jar')
[WARNING] /notnfs/git/eclipse.jdt.debug/org.eclipse.jdt.debug/model/org/eclipse/jdt/internal/debug/core/hcr/JavaHotCodeReplaceManager.java:[711]
    bytes = Util.getResourceContentsAsByteArray((IFile) resource);
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
...
11 problems (11 warnings)
error: warnings found and -failOnWarning specified

Util and CompilerOptions references are causing the warnings.


--
Roland Grunberg

_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: Add maven.compiler.failOnWarning to gerrit jobs

Daniel Megert
 Shouldn't this appear on he main status page? No one is looking at the logs. Why is it not there?

Dani



From:        Roland Grunberg <[hidden email]>
To:        "Eclipse JDT general developers list." <[hidden email]>
Date:        24.09.2019 19:50
Subject:        [EXTERNAL] Re: [jdt-dev] Add maven.compiler.failOnWarning to gerrit jobs
Sent by:        [hidden email]




On Tue, 2019-09-24 at 17:49 +0200, Daniel Megert wrote:
> Where did you see the warning for JDT Debug? Looking at
https://ci.eclipse.org/jdt/job/eclipse.jdt.debug-Gerrit/888/seemsto be free of warnings.

I'm seeing :

[INFO] --- tycho-compiler-plugin:1.5.0-SNAPSHOT:compile (default-compile) @ org.eclipse.jdt.debug ---
[INFO] Compiling 121 source files to /notnfs/git/eclipse.jdt.debug/org.eclipse.jdt.debug/target/jdi.jar-classes
[INFO] Compiling 352 source files to /notnfs/git/eclipse.jdt.debug/org.eclipse.jdt.debug/target/jdimodel.jar-classes
[WARNING] /notnfs/git/eclipse.jdt.debug/org.eclipse.jdt.debug/model/org/eclipse/jdt/internal/debug/core/hcr/JavaHotCodeReplaceManager.java:[72]
   import org.eclipse.jdt.internal.core.util.Util;
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Discouraged access: The type 'Util' is not API (restriction on classpath entry '/notnfs/tmp/m2/p2/osgi/bundle/org.eclipse.jdt.core/3.20.0.v20190923-1401/org.eclipse.jdt.core-3.20.0.v20190923-1401.jar')
[WARNING] /notnfs/git/eclipse.jdt.debug/org.eclipse.jdt.debug/model/org/eclipse/jdt/internal/debug/core/hcr/JavaHotCodeReplaceManager.java:[711]
   bytes = Util.getResourceContentsAsByteArray((IFile) resource);
           ^^^^
Discouraged access: The type 'Util' is not API (restriction on classpath entry '/notnfs/tmp/m2/p2/osgi/bundle/org.eclipse.jdt.core/3.20.0.v20190923-1401/org.eclipse.jdt.core-3.20.0.v20190923-1401.jar')
[WARNING] /notnfs/git/eclipse.jdt.debug/org.eclipse.jdt.debug/model/org/eclipse/jdt/internal/debug/core/hcr/JavaHotCodeReplaceManager.java:[711]
   bytes = Util.getResourceContentsAsByteArray((IFile) resource);
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
...
11 problems (11 warnings)
error: warnings found and -failOnWarning specified

Util and CompilerOptions references are causing the warnings.


--
Roland Grunberg

_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev





_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: Add maven.compiler.failOnWarning to gerrit jobs

Roland Grunberg
On Tue, Sep 24, 2019 at 6:03 PM Daniel Megert <[hidden email]> wrote:
>
>  Shouldn't this appear on he main status page? No one is looking at the logs. Why is it not there?

The warnings are also visible on the platform downloads page. I could add
-Dmaven.compiler.failOnWarning for eclipse.jdt.ui once the JIRO migration
is stabilized, since there are no existing warnings.

I've also opened up https://bugs.eclipse.org/bugs/show_bug.cgi?id=551469
to address some of the warnings in jdt.debug.

--
Roland Grunberg

_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: Add maven.compiler.failOnWarning to gerrit jobs

Daniel Megert
> The warnings are also visible on the platform downloads page.

Yes, but how does this help the contributor if there's no warning there but the Gerrit change fails?

Dani



From:        Roland Grunberg <[hidden email]>
To:        "Eclipse JDT general developers list." <[hidden email]>
Date:        25.09.2019 17:55
Subject:        [EXTERNAL] Re: [jdt-dev] Add maven.compiler.failOnWarning to gerrit jobs
Sent by:        [hidden email]




On Tue, Sep 24, 2019 at 6:03 PM Daniel Megert <[hidden email]> wrote:
>
>  Shouldn't this appear on he main status page? No one is looking at the logs. Why is it not there?

The warnings are also visible on the platform downloads page. I could add
-Dmaven.compiler.failOnWarning for eclipse.jdt.ui once the JIRO migration
is stabilized, since there are no existing warnings.

I've also opened up
https://bugs.eclipse.org/bugs/show_bug.cgi?id=551469
to address some of the warnings in jdt.debug.

--
Roland Grunberg

_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev





_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: Add maven.compiler.failOnWarning to gerrit jobs

Aleksandar Kurtakov


On Wed, Sep 25, 2019 at 6:58 PM Daniel Megert <[hidden email]> wrote:
> The warnings are also visible on the platform downloads page.

Yes, but how does this help the contributor if there's no warning there but the Gerrit change fails?

The contributor will see the warning in his code and right after that the build will stop.



Dani



From:        Roland Grunberg <[hidden email]>
To:        "Eclipse JDT general developers list." <[hidden email]>
Date:        25.09.2019 17:55
Subject:        [EXTERNAL] Re: [jdt-dev] Add maven.compiler.failOnWarning to gerrit jobs
Sent by:        [hidden email]




On Tue, Sep 24, 2019 at 6:03 PM Daniel Megert <[hidden email]> wrote:
>
>  Shouldn't this appear on he main status page? No one is looking at the logs. Why is it not there?

The warnings are also visible on the platform downloads page. I could add
-Dmaven.compiler.failOnWarning for eclipse.jdt.ui once the JIRO migration
is stabilized, since there are no existing warnings.

I've also opened up
https://bugs.eclipse.org/bugs/show_bug.cgi?id=551469
to address some of the warnings in jdt.debug.

--
Roland Grunberg

_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev




_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev


--
Alexander Kurtakov
Red Hat Eclipse Team

_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: Add maven.compiler.failOnWarning to gerrit jobs

Daniel Megert
I thought the main idea of the API Tools check in Gerrit is to catch things that the contributor does not see in his workspace, e.g. because API Tools is not set up (correctly). My problem is that it fails on warning but the warning is not shown by the job, as opposed to "normal" warnings.

Dani



From:        Aleksandar Kurtakov <[hidden email]>
To:        "Eclipse JDT general developers list." <[hidden email]>
Date:        25.09.2019 18:12
Subject:        [EXTERNAL] Re: [jdt-dev] Add maven.compiler.failOnWarning to gerrit jobs
Sent by:        [hidden email]






On Wed, Sep 25, 2019 at 6:58 PM Daniel Megert <daniel_megert@...> wrote:
> The warnings are also visible on the platform downloads page.

Yes, but how does this help the contributor if there's no warning there but the Gerrit change fails?


The contributor will see the warning in his code and right after that the build will stop.



Dani




From:        
Roland Grunberg <rgrunber@...>
To:        
"Eclipse JDT general developers list." <[hidden email]>
Date:        
25.09.2019 17:55
Subject:        
[EXTERNAL] Re: [jdt-dev] Add maven.compiler.failOnWarning to gerrit jobs
Sent by:        
[hidden email]





On Tue, Sep 24, 2019 at 6:03 PM Daniel Megert <
daniel_megert@...> wrote:
>
>  Shouldn't this appear on he main status page? No one is looking at the logs. Why is it not there?

The warnings are also visible on the platform downloads page. I could add
-Dmaven.compiler.failOnWarning for eclipse.jdt.ui once the JIRO migration
is stabilized, since there are no existing warnings.

I've also opened up
https://bugs.eclipse.org/bugs/show_bug.cgi?id=551469
to address some of the warnings in jdt.debug.

--
Roland Grunberg

_______________________________________________
jdt-dev mailing list

[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://www.eclipse.org/mailman/listinfo/jdt-dev




_______________________________________________
jdt-dev mailing list

[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://www.eclipse.org/mailman/listinfo/jdt-dev




--

Alexander Kurtakov
Red Hat Eclipse Team_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev



_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: Add maven.compiler.failOnWarning to gerrit jobs

Aleksandar Kurtakov


On Wed, Sep 25, 2019 at 7:18 PM Daniel Megert <[hidden email]> wrote:
I thought the main idea of the API Tools check in Gerrit is to catch things that the contributor does not see in his workspace, e.g. because API Tools is not set up (correctly). My problem is that it fails on warning but the warning is not shown by the job, as opposed to "normal" warnings.

This is a problem with jenkins warning plugin not properly gathering all warnings in it's report. Nothing we can fix but feel free to report the issue to them :).
We will enable failOnWarning only when THERE ARE NO EXISTING WARNINGS BREAKING THE BUILD. That way it will prevent introducing new warnings in the codebase.
Regarding not being visible on the job result page but rather in the log - same with compile issues - one has to read the log to see them.
 


Dani



From:        Aleksandar Kurtakov <[hidden email]>
To:        "Eclipse JDT general developers list." <[hidden email]>
Date:        25.09.2019 18:12
Subject:        [EXTERNAL] Re: [jdt-dev] Add maven.compiler.failOnWarning to gerrit jobs
Sent by:        [hidden email]






On Wed, Sep 25, 2019 at 6:58 PM Daniel Megert <[hidden email]> wrote:
> The warnings are also visible on the platform downloads page.

Yes, but how does this help the contributor if there's no warning there but the Gerrit change fails?


The contributor will see the warning in his code and right after that the build will stop.



Dani




From:        
Roland Grunberg <[hidden email]>
To:        
"Eclipse JDT general developers list." <[hidden email]>
Date:        
25.09.2019 17:55
Subject:        
[EXTERNAL] Re: [jdt-dev] Add maven.compiler.failOnWarning to gerrit jobs
Sent by:        
[hidden email]





On Tue, Sep 24, 2019 at 6:03 PM Daniel Megert <
[hidden email]> wrote:
>
>  Shouldn't this appear on he main status page? No one is looking at the logs. Why is it not there?

The warnings are also visible on the platform downloads page. I could add
-Dmaven.compiler.failOnWarning for eclipse.jdt.ui once the JIRO migration
is stabilized, since there are no existing warnings.

I've also opened up
https://bugs.eclipse.org/bugs/show_bug.cgi?id=551469
to address some of the warnings in jdt.debug.

--
Roland Grunberg

_______________________________________________
jdt-dev mailing list

[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://www.eclipse.org/mailman/listinfo/jdt-dev




_______________________________________________
jdt-dev mailing list

[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://www.eclipse.org/mailman/listinfo/jdt-dev




--

Alexander Kurtakov
Red Hat Eclipse Team_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev


_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev


--
Alexander Kurtakov
Red Hat Eclipse Team

_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: Add maven.compiler.failOnWarning to gerrit jobs

Lars Vogel-2
Failing the build for introducing new warnings will be super helpful. Thanks Roland and Alex for working on this.

Best regards, Lars

Aleksandar Kurtakov <[hidden email]> schrieb am Mi., 25. Sep. 2019, 18:22:


On Wed, Sep 25, 2019 at 7:18 PM Daniel Megert <[hidden email]> wrote:
I thought the main idea of the API Tools check in Gerrit is to catch things that the contributor does not see in his workspace, e.g. because API Tools is not set up (correctly). My problem is that it fails on warning but the warning is not shown by the job, as opposed to "normal" warnings.

This is a problem with jenkins warning plugin not properly gathering all warnings in it's report. Nothing we can fix but feel free to report the issue to them :).
We will enable failOnWarning only when THERE ARE NO EXISTING WARNINGS BREAKING THE BUILD. That way it will prevent introducing new warnings in the codebase.
Regarding not being visible on the job result page but rather in the log - same with compile issues - one has to read the log to see them.
 


Dani



From:        Aleksandar Kurtakov <[hidden email]>
To:        "Eclipse JDT general developers list." <[hidden email]>
Date:        25.09.2019 18:12
Subject:        [EXTERNAL] Re: [jdt-dev] Add maven.compiler.failOnWarning to gerrit jobs
Sent by:        [hidden email]






On Wed, Sep 25, 2019 at 6:58 PM Daniel Megert <[hidden email]> wrote:
> The warnings are also visible on the platform downloads page.

Yes, but how does this help the contributor if there's no warning there but the Gerrit change fails?


The contributor will see the warning in his code and right after that the build will stop.



Dani




From:        
Roland Grunberg <[hidden email]>
To:        
"Eclipse JDT general developers list." <[hidden email]>
Date:        
25.09.2019 17:55
Subject:        
[EXTERNAL] Re: [jdt-dev] Add maven.compiler.failOnWarning to gerrit jobs
Sent by:        
[hidden email]





On Tue, Sep 24, 2019 at 6:03 PM Daniel Megert <
[hidden email]> wrote:
>
>  Shouldn't this appear on he main status page? No one is looking at the logs. Why is it not there?

The warnings are also visible on the platform downloads page. I could add
-Dmaven.compiler.failOnWarning for eclipse.jdt.ui once the JIRO migration
is stabilized, since there are no existing warnings.

I've also opened up
https://bugs.eclipse.org/bugs/show_bug.cgi?id=551469
to address some of the warnings in jdt.debug.

--
Roland Grunberg

_______________________________________________
jdt-dev mailing list

[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://www.eclipse.org/mailman/listinfo/jdt-dev




_______________________________________________
jdt-dev mailing list

[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://www.eclipse.org/mailman/listinfo/jdt-dev




--

Alexander Kurtakov
Red Hat Eclipse Team_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev


_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev


--
Alexander Kurtakov
Red Hat Eclipse Team
_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev

_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: Add maven.compiler.failOnWarning to gerrit jobs

Daniel Megert
In reply to this post by Aleksandar Kurtakov
> Regarding not being visible on the job result page but rather in the log - same with compile issues - one has to read the log to see them.

IIRC "normal" compile warnings show up as one icon on the status page and clicking on it gives the report. But I agree, we have other checks/failures where one has to look at the log.

So, let's try it. Who's going to enable it?

Dani



From:        Aleksandar Kurtakov <[hidden email]>
To:        "Eclipse JDT general developers list." <[hidden email]>
Date:        25.09.2019 18:22
Subject:        [EXTERNAL] Re: [jdt-dev] Add maven.compiler.failOnWarning to gerrit jobs
Sent by:        [hidden email]






On Wed, Sep 25, 2019 at 7:18 PM Daniel Megert <daniel_megert@...> wrote:
I thought the main idea of the API Tools check in Gerrit is to catch things that the contributor does not see in his workspace, e.g. because API Tools is not set up (correctly). My problem is that it fails on warning but the warning is not shown by the job, as opposed to "normal" warnings.

This is a problem with jenkins warning plugin not properly gathering all warnings in it's report. Nothing we can fix but feel free to report the issue to them :).
We will enable failOnWarning only when THERE ARE NO EXISTING WARNINGS BREAKING THE BUILD. That way it will prevent introducing new warnings in the codebase.
Regarding not being visible on the job result page but rather in the log - same with compile issues - one has to read the log to see them.
 



Dani




From:        
Aleksandar Kurtakov <akurtako@...>
To:        
"Eclipse JDT general developers list." <[hidden email]>
Date:        
25.09.2019 18:12
Subject:        
[EXTERNAL] Re: [jdt-dev] Add maven.compiler.failOnWarning to gerrit jobs
Sent by:        
[hidden email]







On Wed, Sep 25, 2019 at 6:58 PM Daniel Megert <
daniel_megert@...> wrote:
>
The warnings are also visible on the platform downloads page.

Yes, but how does this help the contributor if there's no warning there but the Gerrit change fails?


The contributor will see the warning in his code and right after that the build will stop.



Dani




From:        
Roland Grunberg <rgrunber@...>
To:        
"Eclipse JDT general developers list." <[hidden email]>
Date:        
25.09.2019 17:55
Subject:        
[EXTERNAL] Re: [jdt-dev] Add maven.compiler.failOnWarning to gerrit jobs
Sent by:        
[hidden email]





On Tue, Sep 24, 2019 at 6:03 PM Daniel Megert <
daniel_megert@...> wrote:
>
>  Shouldn't this appear on he main status page? No one is looking at the logs. Why is it not there?

The warnings are also visible on the platform downloads page. I could add
-Dmaven.compiler.failOnWarning for eclipse.jdt.ui once the JIRO migration
is stabilized, since there are no existing warnings.

I've also opened up
https://bugs.eclipse.org/bugs/show_bug.cgi?id=551469
to address some of the warnings in jdt.debug.

--
Roland Grunberg

_______________________________________________
jdt-dev mailing list

[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://www.eclipse.org/mailman/listinfo/jdt-dev




_______________________________________________
jdt-dev mailing list

[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://www.eclipse.org/mailman/listinfo/jdt-dev




--
Alexander Kurtakov
Red Hat Eclipse Team
_______________________________________________
jdt-dev mailing list

[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://www.eclipse.org/mailman/listinfo/jdt-dev


_______________________________________________
jdt-dev mailing list

[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://www.eclipse.org/mailman/listinfo/jdt-dev




--

Alexander Kurtakov
Red Hat Eclipse Team_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev



_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: Add maven.compiler.failOnWarning to gerrit jobs

Aleksandar Kurtakov


On Thu, Sep 26, 2019 at 10:41 AM Daniel Megert <[hidden email]> wrote:
> Regarding not being visible on the job result page but rather in the log - same with compile issues - one has to read the log to see them.

IIRC "normal" compile warnings show up as one icon on the status page and clicking on it gives the report.

That's true for non JDT jobs - JDT jobs are not configured to publish warnings (something that only JDT committer can do). Roland will do that once JIRO migration is done.
 
But I agree, we have other checks/failures where one has to look at the log.


So, let's try it. Who's going to enable it?

Again Roland was "voluntold" :).
 


Dani



From:        Aleksandar Kurtakov <[hidden email]>
To:        "Eclipse JDT general developers list." <[hidden email]>
Date:        25.09.2019 18:22
Subject:        [EXTERNAL] Re: [jdt-dev] Add maven.compiler.failOnWarning to gerrit jobs
Sent by:        [hidden email]






On Wed, Sep 25, 2019 at 7:18 PM Daniel Megert <[hidden email]> wrote:
I thought the main idea of the API Tools check in Gerrit is to catch things that the contributor does not see in his workspace, e.g. because API Tools is not set up (correctly). My problem is that it fails on warning but the warning is not shown by the job, as opposed to "normal" warnings.

This is a problem with jenkins warning plugin not properly gathering all warnings in it's report. Nothing we can fix but feel free to report the issue to them :).
We will enable failOnWarning only when THERE ARE NO EXISTING WARNINGS BREAKING THE BUILD. That way it will prevent introducing new warnings in the codebase.
Regarding not being visible on the job result page but rather in the log - same with compile issues - one has to read the log to see them.
 



Dani




From:        
Aleksandar Kurtakov <[hidden email]>
To:        
"Eclipse JDT general developers list." <[hidden email]>
Date:        
25.09.2019 18:12
Subject:        
[EXTERNAL] Re: [jdt-dev] Add maven.compiler.failOnWarning to gerrit jobs
Sent by:        
[hidden email]







On Wed, Sep 25, 2019 at 6:58 PM Daniel Megert <
[hidden email]> wrote:
>
The warnings are also visible on the platform downloads page.

Yes, but how does this help the contributor if there's no warning there but the Gerrit change fails?


The contributor will see the warning in his code and right after that the build will stop.



Dani




From:        
Roland Grunberg <[hidden email]>
To:        
"Eclipse JDT general developers list." <[hidden email]>
Date:        
25.09.2019 17:55
Subject:        
[EXTERNAL] Re: [jdt-dev] Add maven.compiler.failOnWarning to gerrit jobs
Sent by:        
[hidden email]





On Tue, Sep 24, 2019 at 6:03 PM Daniel Megert <
[hidden email]> wrote:
>
>  Shouldn't this appear on he main status page? No one is looking at the logs. Why is it not there?

The warnings are also visible on the platform downloads page. I could add
-Dmaven.compiler.failOnWarning for eclipse.jdt.ui once the JIRO migration
is stabilized, since there are no existing warnings.

I've also opened up
https://bugs.eclipse.org/bugs/show_bug.cgi?id=551469
to address some of the warnings in jdt.debug.

--
Roland Grunberg

_______________________________________________
jdt-dev mailing list

[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://www.eclipse.org/mailman/listinfo/jdt-dev




_______________________________________________
jdt-dev mailing list

[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://www.eclipse.org/mailman/listinfo/jdt-dev




--
Alexander Kurtakov
Red Hat Eclipse Team
_______________________________________________
jdt-dev mailing list

[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://www.eclipse.org/mailman/listinfo/jdt-dev


_______________________________________________
jdt-dev mailing list

[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://www.eclipse.org/mailman/listinfo/jdt-dev




--

Alexander Kurtakov
Red Hat Eclipse Team_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev


_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev


--
Alexander Kurtakov
Red Hat Eclipse Team

_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev
Reply | Threaded
Open this post in threaded view
|

Add maven.compiler.failOnWarning to gerrit jobs

Roland Grunberg
On Thu, 2019-09-26 at 10:59 +0300, Aleksandar Kurtakov wrote:
> 
> 
> On Thu, Sep 26, 2019 at 10:41 AM Daniel Megert <[hidden email]> wrote:
> > > Regarding not being visible on the job result page but rather in the log - same with compile issues - one has to read the log to see them.
> > 
> > IIRC "normal" compile warnings show up as one icon on the status page and clicking on it gives the report. 
> 
> That's true for non JDT jobs - JDT jobs are not configured to publish warnings (something that only JDT committer can do). Roland will do that once JIRO migration is done.
>  
> > But I agree, we have other checks/failures where one has to look at the log. 
> > 
> > So, let's try it. Who's going to enable it?
> 
> Again Roland was "voluntold" :).

I've enabled maven.compiler.failOnWarning for https://ci.eclipse.org/jdt/job/eclipse.jdt.ui-Gerrit .

We can work towards enabling it in the other gerrit instances when we fix the existing warnings.

Cheers,
-- 
Roland Grunberg

_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev