CDT 9.12 Api changes bug 510789

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

CDT 9.12 Api changes bug 510789

Mark B
Hi,

for CDT 9.11 I changed a public API for this bug 510789. Since it was a
major change we revert the commit. What's the current status and plan
here? Are we able to perform this kind of change now? Do we plan to do
it for CDT 10?

Thanks.
_______________________________________________
cdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: CDT 9.12 Api changes bug 510789

Alexander Fedorov
Hi Marco,

The general rule is to avoid breaking API changes if possible and rather
add new fields, methods, types.
If it is not possible or has no sense for some reason - I would like to
have closer look at the surrounding types and use this opportunity to
improve the API more consistently.
I suggest to switch to the bug 510789 and discuss the desired API change
in details there.

Regards,
AF

31.03.2020 9:23, marco пишет:

> Hi,
>
> for CDT 9.11 I changed a public API for this bug 510789. Since it was
> a major change we revert the commit. What's the current status and
> plan here? Are we able to perform this kind of change now? Do we plan
> to do it for CDT 10?
>
> Thanks.
> _______________________________________________
> cdt-dev mailing list
> [hidden email]
> To unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/cdt-dev
>

_______________________________________________
cdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: CDT 9.12 Api changes bug 510789

Mark B
It was quite impossible to do with the exception of really bad hacks or code duplication. If you want to take a look it's great. We can add other comments in the bug report. Thanks.

Il mar 31 mar 2020, 09:15 Alexander Fedorov <[hidden email]> ha scritto:
Hi Marco,

The general rule is to avoid breaking API changes if possible and rather
add new fields, methods, types.
If it is not possible or has no sense for some reason - I would like to
have closer look at the surrounding types and use this opportunity to
improve the API more consistently.
I suggest to switch to the bug 510789 and discuss the desired API change
in details there.

Regards,
AF

31.03.2020 9:23, marco пишет:
> Hi,
>
> for CDT 9.11 I changed a public API for this bug 510789. Since it was
> a major change we revert the commit. What's the current status and
> plan here? Are we able to perform this kind of change now? Do we plan
> to do it for CDT 10?
>
> Thanks.
> _______________________________________________
> cdt-dev mailing list
> [hidden email]
> To unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/cdt-dev
>

_______________________________________________
cdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cdt-dev

_______________________________________________
cdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: CDT 9.12 Api changes bug 510789

Jonah Graham
Hi Marco,

In light of the decision announced earlier today, you should have the flexibility to add this to CDT 10.0.0 and bump the major version as needed. 

It would be great to fix the API of this class to avoid this problem in the future, but that can and should be a separate bug and gerrit(s).

Thanks,
Jonah
~~~
Jonah Graham
Kichwa Coders
www.kichwacoders.com


On Tue, 31 Mar 2020 at 11:30, Mark B <[hidden email]> wrote:
It was quite impossible to do with the exception of really bad hacks or code duplication. If you want to take a look it's great. We can add other comments in the bug report. Thanks.

Il mar 31 mar 2020, 09:15 Alexander Fedorov <[hidden email]> ha scritto:
Hi Marco,

The general rule is to avoid breaking API changes if possible and rather
add new fields, methods, types.
If it is not possible or has no sense for some reason - I would like to
have closer look at the surrounding types and use this opportunity to
improve the API more consistently.
I suggest to switch to the bug 510789 and discuss the desired API change
in details there.

Regards,
AF

31.03.2020 9:23, marco пишет:
> Hi,
>
> for CDT 9.11 I changed a public API for this bug 510789. Since it was
> a major change we revert the commit. What's the current status and
> plan here? Are we able to perform this kind of change now? Do we plan
> to do it for CDT 10?
>
> Thanks.
> _______________________________________________
> cdt-dev mailing list
> [hidden email]
> To unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/cdt-dev
>

_______________________________________________
cdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cdt-dev
_______________________________________________
cdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cdt-dev

_______________________________________________
cdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: CDT 9.12 Api changes bug 510789

Mark B
ok, thanks. From your bug report changes we are going to release only a maintenance release in June with few big fixies. It seems a good plan.

Il mer 1 apr 2020, 18:24 Jonah Graham <[hidden email]> ha scritto:
Hi Marco,

In light of the decision announced earlier today, you should have the flexibility to add this to CDT 10.0.0 and bump the major version as needed. 

It would be great to fix the API of this class to avoid this problem in the future, but that can and should be a separate bug and gerrit(s).

Thanks,
Jonah
~~~
Jonah Graham
Kichwa Coders
www.kichwacoders.com


On Tue, 31 Mar 2020 at 11:30, Mark B <[hidden email]> wrote:
It was quite impossible to do with the exception of really bad hacks or code duplication. If you want to take a look it's great. We can add other comments in the bug report. Thanks.

Il mar 31 mar 2020, 09:15 Alexander Fedorov <[hidden email]> ha scritto:
Hi Marco,

The general rule is to avoid breaking API changes if possible and rather
add new fields, methods, types.
If it is not possible or has no sense for some reason - I would like to
have closer look at the surrounding types and use this opportunity to
improve the API more consistently.
I suggest to switch to the bug 510789 and discuss the desired API change
in details there.

Regards,
AF

31.03.2020 9:23, marco пишет:
> Hi,
>
> for CDT 9.11 I changed a public API for this bug 510789. Since it was
> a major change we revert the commit. What's the current status and
> plan here? Are we able to perform this kind of change now? Do we plan
> to do it for CDT 10?
>
> Thanks.
> _______________________________________________
> cdt-dev mailing list
> [hidden email]
> To unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/cdt-dev
>

_______________________________________________
cdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cdt-dev
_______________________________________________
cdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cdt-dev
_______________________________________________
cdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cdt-dev

_______________________________________________
cdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cdt-dev