Gerrit triggers on commit message change?

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Gerrit triggers on commit message change?

15 knots
Hi, in [1] (patchset 6), I can see that a verification build was triggered due to a change in the commit message.
Is this really necessary? IMHO, that is just burning CPU-cycles.

Martin


_______________________________________________
cdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: Gerrit triggers on commit message change?

Jonah Graham
Thanks Martin for the suggestion! I just looked into gerrit settings and there is one that is as below that I have now turned on. If anyone notices if builds that should be running are no longer running, please let me know.

Jonah

Exclude changes without code change from triggering build

If set, this will ignore any patchset which Gerrit considers without any code changes from triggering this build. These patches did not contain any differences in code from the previous patchset and did not change the parent commit.


~~~
Jonah Graham
Kichwa Coders
www.kichwacoders.com


On Fri, 8 May 2020 at 07:02, 15 knots <[hidden email]> wrote:
Hi, in [1] (patchset 6), I can see that a verification build was triggered due to a change in the commit message.
Is this really necessary? IMHO, that is just burning CPU-cycles.

Martin

_______________________________________________
cdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cdt-dev

_______________________________________________
cdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: Gerrit triggers on commit message change?

15 knots
Am Fr., 8. Mai 2020 um 13:11 Uhr schrieb Jonah Graham <[hidden email]>:
Thanks Martin for the suggestion! I just looked into gerrit settings and there is one that is as below that I have now turned on. If anyone notices if builds that should be running are no longer running, please let me know.

Jonah

Exclude changes without code change from triggering build

If set, this will ignore any patchset which Gerrit considers without any code changes from triggering this build. These patches did not contain any differences in code from the previous patchset and did not change the parent commit.

Yes, that is what I use with jenkins@work, too. I also enabled the 'silent start' option to get rid of the annoying 'Build started' messages in gerrit.

Martin

_______________________________________________
cdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: Gerrit triggers on commit message change?

Jonah Graham

~~~
Jonah Graham
Kichwa Coders
www.kichwacoders.com


On Fri, 8 May 2020 at 08:17, 15 knots <[hidden email]> wrote:
Am Fr., 8. Mai 2020 um 13:11 Uhr schrieb Jonah Graham <[hidden email]>:
Thanks Martin for the suggestion! I just looked into gerrit settings and there is one that is as below that I have now turned on. If anyone notices if builds that should be running are no longer running, please let me know.

Jonah

Exclude changes without code change from triggering build

If set, this will ignore any patchset which Gerrit considers without any code changes from triggering this build. These patches did not contain any differences in code from the previous patchset and did not change the parent commit.

Yes, that is what I use with jenkins@work, too. I also enabled the 'silent start' option to get rid of the annoying 'Build started' messages in gerrit.


I have changed to silent start mode to try it out. I am very used to seeing those start messages and for example use them to check if the (relatively) short running code cleanliness has passed/failed before all the other reports are back in, so it may be an adjustment for me (and others :-).

Thanks for the suggestion and please keep them coming!

Jonah

_______________________________________________
cdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: Gerrit triggers on commit message change?

15 knots

Am Fr., 8. Mai 2020 um 16:14 Uhr schrieb Jonah Graham <[hidden email]>:
I have changed to silent start mode to try it out. I am very used to seeing those start messages and for example use them to check if the (relatively) short running code cleanliness has passed/failed before all the other reports are back in, so it may be an adjustment for me (and others :-).
If a verification build fails, Jenkins will put its -1 in any case.

Martin 

_______________________________________________
cdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: Gerrit triggers on commit message change?

15 knots
In reply to this post by Jonah Graham
Am Fr., 8. Mai 2020 um 16:14 Uhr schrieb Jonah Graham <[hidden email]>:
On Fri, 8 May 2020 at 08:17, 15 knots <[hidden email]> wrote:
Am Fr., 8. Mai 2020 um 13:11 Uhr schrieb Jonah Graham <[hidden email]>:

Yes, that is what I use with jenkins@work, too. I also enabled the 'silent start' option to get rid of the annoying 'Build started' messages in gerrit.


I have changed to silent start mode to try it out. I am very used to seeing those start messages and for example use them to check if the (relatively) short running code cleanliness has passed/failed before all the other reports are back in, so it may be an adjustment for me (and others :-).

Thanks for enabling silent mode!
My INBOX as well as the gerrit history no longer clutters up with 'Build started' messages. This makes it a lot easier to focus on the relevant review messages.

_______________________________________________
cdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cdt-dev