Hang in LSF target system configuration issuing 'bqueues -l' command

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Hang in LSF target system configuration issuing 'bqueues -l' command

David Wootton-2

I found a hang using the LSF interactive target system configuration where I click the 'List' button next to the queue name. When I do this, the progress monitor for the command processor displays but the command never completes and the run configuration dialog is locked until I cancel the progress monitor.

It looks like the problem is the way that I coded the command processing in the org.eclipse.ptp.rm.ibm.lsf.ui.LSFCommand.runCommand() method is wrong for handling a 'bqueues -l' command with a lot of output. In my case, the output is about 1200 lines.

After experimenting a bit, it looks like the bqueues command runs, and the runCommand method waits for the command to complete. However, since nothing is reading the stdout stream until the bqueues command completes, I end up with a deadlock condition in Eclipse code.

I think the solution is to create the bqueues command process object, get the stdout and stderr stream handles, then create two threads to read these streams while the command is running, capturing the info I need, and then returning thta to the caller when the command completes.

I think I can make the required changes. The problem is that while I still have a committer id that is enabled for PTP, I have no idea what the current process is to get a fix into the PTP repository.

Can I get help getting this change into the repo, where I'm probably going to end up starting this in early January, or should I just clone the code, rename the target system configurations and add those to my own plugins?

Dave

_______________________________________________
ptp-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ptp-dev

Reply | Threaded
Open this post in threaded view
|

Re: Hang in LSF target system configuration issuing 'bqueues -l' command

Greg Watson-2
Hi Dave,

You're still a committer, so you can push a change to gerrit. Once it's reviewed you can commit it to the repo. If you want the change in Oxygen.3 then commit to the 9.1 branch, otherwise for Photon use master.

Let me know if you need any other help.

Regards,
Greg

On Dec 11, 2017, at 11:53 AM, David Wootton <[hidden email]> wrote:

I found a hang using the LSF interactive target system configuration where I click the 'List' button next to the queue name. When I do this, the progress monitor for the command processor displays but the command never completes and the run configuration dialog is locked until I cancel the progress monitor.

It looks like the problem is the way that I coded the command processing in the org.eclipse.ptp.rm.ibm.lsf.ui.LSFCommand.runCommand() method is wrong for handling a 'bqueues -l' command with a lot of output. In my case, the output is about 1200 lines.

After experimenting a bit, it looks like the bqueues command runs, and the runCommand method waits for the command to complete. However, since nothing is reading the stdout stream until the bqueues command completes, I end up with a deadlock condition in Eclipse code.

I think the solution is to create the bqueues command process object, get the stdout and stderr stream handles, then create two threads to read these streams while the command is running, capturing the info I need, and then returning thta to the caller when the command completes.

I think I can make the required changes. The problem is that while I still have a committer id that is enabled for PTP, I have no idea what the current process is to get a fix into the PTP repository.

Can I get help getting this change into the repo, where I'm probably going to end up starting this in early January, or should I just clone the code, rename the target system configurations and add those to my own plugins?

Dave

_______________________________________________
ptp-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ptp-dev


_______________________________________________
ptp-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ptp-dev