Help with updating plug-in for Eclipse from the Eclipse Mars to the Eclipse Neon.2

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Help with updating plug-in for Eclipse from the Eclipse Mars to the Eclipse Neon.2

Катунина Евгения
Hi all, 

I faced the issue connected with the CDI to DSF transition when I was trying to upgrade my plug-in to the Eclipse Neon.2. Previous developer of this plug-in replaced the usage of the CDI debugger with the DSF one but one of the classes which is currently used extends the CDebuggerTab class removed in the CDT 9.0. Now I have difficulties with changing this code accordingly to the new API. Could you please explain what can I do with this issue? This is the link to the repository with the plug-in —  https://github.com/foss-for-synopsys-dwc-arc-processors/arc_gnu_eclipse and this is the link to the inheritor of the CDebuggerTab — 
https://github.com/foss-for-synopsys-dwc-arc-processors/arc_gnu_eclipse/blob/master/com.arc.embeddedcdt/src/com/arc/embeddedcdt/gui/EmbeddedDebuggerTab.java . 
Thank you, 
Evgeniya



_______________________________________________
cdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: Help with updating plug-in for Eclipse from the Eclipse Mars to the Eclipse Neon.2

Jonah Graham
Hi Evgeniya,

(thanks for bringing this on to the cdt-dev list)

Once you pointed me at all the source code it became much more clear
what was needed. When you transitioned from CDI to DSF you were able
to continue to use the CDI debugger tab for the DSF launch. The simple
solution is to extend the non-API*
org.eclipse.cdt.dsf.gdb.internal.ui.launching.CDebuggerTab instead.
Despite the name being the same, you can't simply change the extends
line. I have created a PR for you [1] that shows the changes. I also
made a couple of other updates which you may or may not want.

* I don't know for sure why this isn't API, but it is regularly
accessed outside of API. My guess is the original design intended
everyone to create their own type of launch delegate and re-use the
UI, but in practice what you have done of having your own launch type
is quite common and more accessible to users. If anyone else on the
list knows more there may be a better answer.

[1] https://github.com/foss-for-synopsys-dwc-arc-processors/arc_gnu_eclipse/pull/45

Jonah
~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com


On 21 February 2017 at 17:07, Катунина Евгения
<[hidden email]> wrote:

> Hi all,
>
> I faced the issue connected with the CDI to DSF transition when I was trying
> to upgrade my plug-in to the Eclipse Neon.2. Previous developer of this
> plug-in replaced the usage of the CDI debugger with the DSF one but one of
> the classes which is currently used extends the CDebuggerTab class removed
> in the CDT 9.0. Now I have difficulties with changing this code accordingly
> to the new API. Could you please explain what can I do with this issue? This
> is the link to the repository with the plug-in —
> https://github.com/foss-for-synopsys-dwc-arc-processors/arc_gnu_eclipse and
> this is the link to the inheritor of the CDebuggerTab —
> https://github.com/foss-for-synopsys-dwc-arc-processors/arc_gnu_eclipse/blob/master/com.arc.embeddedcdt/src/com/arc/embeddedcdt/gui/EmbeddedDebuggerTab.java
> .
> Thank you,
> Evgeniya
>
>
>
> _______________________________________________
> cdt-dev mailing list
> [hidden email]
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/cdt-dev
_______________________________________________
cdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: Help with updating plug-in for Eclipse from the Eclipse Mars to the Eclipse Neon.2

Evgeniya Katunina
Jonah,

Thank you very much!

Evgeniya

-----Original Message-----
From: [hidden email] [mailto:[hidden email]] On Behalf Of Jonah Graham
Sent: Wednesday, February 22, 2017 12:17 AM
To: CDT General developers list. <[hidden email]>
Subject: Re: [cdt-dev] Help with updating plug-in for Eclipse from the Eclipse Mars to the Eclipse Neon.2

Hi Evgeniya,

(thanks for bringing this on to the cdt-dev list)

Once you pointed me at all the source code it became much more clear what was needed. When you transitioned from CDI to DSF you were able to continue to use the CDI debugger tab for the DSF launch. The simple solution is to extend the non-API* org.eclipse.cdt.dsf.gdb.internal.ui.launching.CDebuggerTab instead.
Despite the name being the same, you can't simply change the extends line. I have created a PR for you [1] that shows the changes. I also made a couple of other updates which you may or may not want.

* I don't know for sure why this isn't API, but it is regularly accessed outside of API. My guess is the original design intended everyone to create their own type of launch delegate and re-use the UI, but in practice what you have done of having your own launch type is quite common and more accessible to users. If anyone else on the list knows more there may be a better answer.

[1] https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_foss-2Dfor-2Dsynopsys-2Ddwc-2Darc-2Dprocessors_arc-5Fgnu-5Feclipse_pull_45&d=DwIGaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=Evd3RDP3ozGDc0l3Ni8qnA1zQe2BgvvQDPKNNUZqR2g&m=8iiigDh4_2r6P-mIlu36pFT2WKFbjWNTQ8ZPxSSmBdg&s=jYt08gA4k9IStGxXSwxEsuj4gwqEF81g7UW5c0SDYB8&e= 

Jonah
~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com


On 21 February 2017 at 17:07, Катунина Евгения <[hidden email]> wrote:

> Hi all,
>
> I faced the issue connected with the CDI to DSF transition when I was
> trying to upgrade my plug-in to the Eclipse Neon.2. Previous developer
> of this plug-in replaced the usage of the CDI debugger with the DSF
> one but one of the classes which is currently used extends the
> CDebuggerTab class removed in the CDT 9.0. Now I have difficulties
> with changing this code accordingly to the new API. Could you please
> explain what can I do with this issue? This is the link to the
> repository with the plug-in —
> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_foss-2
> Dfor-2Dsynopsys-2Ddwc-2Darc-2Dprocessors_arc-5Fgnu-5Feclipse&d=DwIGaQ&
> c=DPL6_X_6JkXFx7AXWqB0tg&r=Evd3RDP3ozGDc0l3Ni8qnA1zQe2BgvvQDPKNNUZqR2g
> &m=8iiigDh4_2r6P-mIlu36pFT2WKFbjWNTQ8ZPxSSmBdg&s=2CHgGsvx0yT1L-gqQiRT4
> TulvP_pTQUwA7rLxKcFDN0&e=  and this is the link to the inheritor of
> the CDebuggerTab —
> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_foss-2
> Dfor-2Dsynopsys-2Ddwc-2Darc-2Dprocessors_arc-5Fgnu-5Feclipse_blob_mast
> er_com.arc.embeddedcdt_src_com_arc_embeddedcdt_gui_EmbeddedDebuggerTab
> .java&d=DwIGaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=Evd3RDP3ozGDc0l3Ni8qnA1zQe2B
> gvvQDPKNNUZqR2g&m=8iiigDh4_2r6P-mIlu36pFT2WKFbjWNTQ8ZPxSSmBdg&s=wR-4QR
> VeHEFc3Ef8F9Gh0mZUeKK9212-GlOanHa4vy4&e=
> .
> Thank you,
> Evgeniya
>
>
>
> _______________________________________________
> cdt-dev mailing list
> [hidden email]
> To change your delivery options, retrieve your password, or
> unsubscribe from this list, visit
> https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_m
> ailman_listinfo_cdt-2Ddev&d=DwIGaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=Evd3RDP3
> ozGDc0l3Ni8qnA1zQe2BgvvQDPKNNUZqR2g&m=8iiigDh4_2r6P-mIlu36pFT2WKFbjWNT
> Q8ZPxSSmBdg&s=Oj-ahC2iRXuowKEaQ8NkYnqqXUxb8AHpybw_PZmFV-s&e=
_______________________________________________
cdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_cdt-2Ddev&d=DwIGaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=Evd3RDP3ozGDc0l3Ni8qnA1zQe2BgvvQDPKNNUZqR2g&m=8iiigDh4_2r6P-mIlu36pFT2WKFbjWNTQ8ZPxSSmBdg&s=Oj-ahC2iRXuowKEaQ8NkYnqqXUxb8AHpybw_PZmFV-s&e= 
_______________________________________________
cdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: Help with updating plug-in for Eclipse from the Eclipse Mars to the Eclipse Neon.2

Evgeniya Katunina
Jonah,

I have an error "Unknown extension point: 'org.eclipse.cdt.debug.core.CDebugger'" with the pull request.

Evgeniya

-----Original Message-----
From: [hidden email] [mailto:[hidden email]] On Behalf Of Evgeniya Katunina
Sent: Wednesday, February 22, 2017 1:49 PM
To: CDT General developers list. <[hidden email]>
Subject: Re: [cdt-dev] Help with updating plug-in for Eclipse from the Eclipse Mars to the Eclipse Neon.2

Jonah,Thank you very much!Evgeniya-----Original Message-----From: [hidden email] [mailto:[hidden email]] On Behalf Of Jonah GrahamSent: Wednesday, February 22, 2017 12:17 AMTo: CDT General developers list. <[hidden email]>Subject: Re: [cdt-dev] Help with updating plug-in for Eclipse from the Eclipse Mars to the Eclipse Neon.2Hi Evgeniya,(thanks for bringing this on to the cdt-dev list)Once you pointed me at all the source code it became much more clear what was needed. When you transitioned from CDI to DSF you were able to continue to use the CDI debugger tab for the DSF launch. The simple solution is to extend the non-API* org.eclipse.cdt.dsf.gdb.internal.ui.launching.CDebuggerTab instead.Despite the name being the same, you can't simply change the extends line. I have created a PR for you [1] that shows the changes. I also made a couple of other updates which you may or may not want.* I don't know for sure why this isn't API, but it is regularly accessed outside of API. My guess is the original design intended everyone to create their own type of launch delegate and re-use the UI, but in practice what you have done of having your own launch type is quite common and more accessible to users. If anyone else on the list knows more there may be a better answer.[1] https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_foss-2Dfor-2Dsynopsys-2Ddwc-2Darc-2Dprocessors_arc-5Fgnu-5Feclipse_pull_45&d=DwIGaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=Evd3RDP3ozGDc0l3Ni8qnA1zQe2BgvvQDPKNNUZqR2g&m=8iiigDh4_2r6P-mIlu36pFT2WKFbjWNTQ8ZPxSSmBdg&s=jYt08gA4k9IStGxXSwxEsuj4gwqEF81g7UW5c0SDYB8&e= Jonah~~~Jonah GrahamKichwa Coders Ltd.www.kichwacoders.comOn 21 February 2017 at 17:07, Катунина Евгения <[hidden email]> wrote:> Hi all,>> I faced the issue connected with the CDI to DSF transition when I was > trying to upgrade my plug-in to the Eclipse Neon.2. Previous developer > of this plug-in replaced the usage of the CDI debugger with the DSF > one but one of the classes which is currently used extends the > CDebuggerTab class removed in the CDT 9.0. Now I have difficulties > with changing this code accordingly to the new API. Could you please > explain what can I do with this issue? This is the link to the > repository with the plug-in — > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_foss-2> Dfor-2Dsynopsys-2Ddwc-2Darc-2Dprocessors_arc-5Fgnu-5Feclipse&d=DwIGaQ&> c=DPL6_X_6JkXFx7AXWqB0tg&r=Evd3RDP3ozGDc0l3Ni8qnA1zQe2BgvvQDPKNNUZqR2g> &m=8iiigDh4_2r6P-mIlu36pFT2WKFbjWNTQ8ZPxSSmBdg&s=2CHgGsvx0yT1L-gqQiRT4> TulvP_pTQUwA7rLxKcFDN0&e=  and this is the link to the inheritor of > the CDebuggerTab — > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_foss-2> Dfor-2Dsynopsys-2Ddwc-2Darc-2Dprocessors_arc-5Fgnu-5Feclipse_blob_mast> er_com.arc.embeddedcdt_src_com_arc_embeddedcdt_gui_EmbeddedDebuggerTab> .java&d=DwIGaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=Evd3RDP3ozGDc0l3Ni8qnA1zQe2B> gvvQDPKNNUZqR2g&m=8iiigDh4_2r6P-mIlu36pFT2WKFbjWNTQ8ZPxSSmBdg&s=wR-4QR> VeHEFc3Ef8F9Gh0mZUeKK9212-GlOanHa4vy4&e=> .> Thank you,> Evgeniya>>>> _______________________________________________> cdt-dev mailing list> [hidden email]> To change your delivery options, retrieve your password, or > unsubscribe from this list, visit > https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_m> ailman_listinfo_cdt-2Ddev&d=DwIGaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=Evd3RDP3> ozGDc0l3Ni8qnA1zQe2BgvvQDPKNNUZqR2g&m=8iiigDh4_2r6P-mIlu36pFT2WKFbjWNT> Q8ZPxSSmBdg&s=Oj-ahC2iRXuowKEaQ8NkYnqqXUxb8AHpybw_PZmFV-s&e=_______________________________________________cdt-dev mailing [hidden email] change your delivery options, retrieve your password, or unsubscribe from this list, visit https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_cdt-2Ddev&d=DwIGaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=Evd3RDP3ozGDc0l3Ni8qnA1zQe2BgvvQDPKNNUZqR2g&m=8iiigDh4_2r6P-mIlu36pFT2WKFbjWNTQ8ZPxSSmBdg&s=Oj-ahC2iRXuowKEaQ8NkYnqqXUxb8AHpybw_PZmFV-s&e= _______________________________________________
cdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_cdt-2Ddev&d=DwIGaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=T2Nu5oC0cFpYft-aWVADZQwW1gKau7VGmdiLGLU-TEU&m=ppgsBK2wE2XhVxgjslVXSDkj9rXyZ0zxxOvopVAWg8U&s=d-YoltjtsszNQ_CX_cSJG3FdFqlw5rSsBv_vzCWi_fM&e= 
_______________________________________________
cdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: Help with updating plug-in for Eclipse from the Eclipse Mars to the Eclipse Neon.2

Jonah Graham
There are other updates that need to be made for it to work with CDT
9.0. That error message is because the extension point no longer
exists as that was how you declared a debugger to CDI, it is not part
of DSF.

(Added relevant comment on PR)


~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com


On 22 February 2017 at 12:43, Evgeniya Katunina
<[hidden email]> wrote:

> Jonah,
>
> I have an error "Unknown extension point: 'org.eclipse.cdt.debug.core.CDebugger'" with the pull request.
>
> Evgeniya
>
> -----Original Message-----
> From: [hidden email] [mailto:[hidden email]] On Behalf Of Evgeniya Katunina
> Sent: Wednesday, February 22, 2017 1:49 PM
> To: CDT General developers list. <[hidden email]>
> Subject: Re: [cdt-dev] Help with updating plug-in for Eclipse from the Eclipse Mars to the Eclipse Neon.2
>
> Jonah,Thank you very much!Evgeniya-----Original Message-----From: [hidden email] [mailto:[hidden email]] On Behalf Of Jonah GrahamSent: Wednesday, February 22, 2017 12:17 AMTo: CDT General developers list. <[hidden email]>Subject: Re: [cdt-dev] Help with updating plug-in for Eclipse from the Eclipse Mars to the Eclipse Neon.2Hi Evgeniya,(thanks for bringing this on to the cdt-dev list)Once you pointed me at all the source code it became much more clear what was needed. When you transitioned from CDI to DSF you were able to continue to use the CDI debugger tab for the DSF launch. The simple solution is to extend the non-API* org.eclipse.cdt.dsf.gdb.internal.ui.launching.CDebuggerTab instead.Despite the name being the same, you can't simply change the extends line. I have created a PR for you [1] that shows the changes. I also made a couple of other updates which you may or may not want.* I don't know for sure why this isn't API, but it is regularly accessed outside of API. My guess is the original design intended everyone to create their own type of launch delegate and re-use the UI, but in practice what you have done of having your own launch type is quite common and more accessible to users. If anyone else on the list knows more there may be a better answer.[1] https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_foss-2Dfor-2Dsynopsys-2Ddwc-2Darc-2Dprocessors_arc-5Fgnu-5Feclipse_pull_45&d=DwIGaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=Evd3RDP3ozGDc0l3Ni8qnA1zQe2BgvvQDPKNNUZqR2g&m=8iiigDh4_2r6P-mIlu36pFT2WKFbjWNTQ8ZPxSSmBdg&s=jYt08gA4k9IStGxXSwxEsuj4gwqEF81g7UW5c0SDYB8&e= Jonah~~~Jonah GrahamKichwa Coders Ltd.www.kichwacoders.comOn 21 February 2017 at 17:07, Катунина Евгения <[hidden email]> wrote:> Hi all,>> I faced the issue connected with the CDI to DSF transition when I was > trying to upgrade my plug-in to the Eclipse Neon.2. Previous developer > of this plug-in replaced the usage of the CDI debugger with the DSF > one but one of the classes which is currently used extends the > CDebuggerTab class removed in the CDT 9.0. Now I have difficulties > with changing this code accordingly to the new API. Could you please > explain what can I do with this issue? This is the link to the > repository with the plug-in — > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_foss-2> Dfor-2Dsynopsys-2Ddwc-2Darc-2Dprocessors_arc-5Fgnu-5Feclipse&d=DwIGaQ&> c=DPL6_X_6JkXFx7AXWqB0tg&r=Evd3RDP3ozGDc0l3Ni8qnA1zQe2BgvvQDPKNNUZqR2g> &m=8iiigDh4_2r6P-mIlu36pFT2WKFbjWNTQ8ZPxSSmBdg&s=2CHgGsvx0yT1L-gqQiRT4> TulvP_pTQUwA7rLxKcFDN0&e=  and this is the link to the inheritor of > the CDebuggerTab — > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_foss-2> Dfor-2Dsynopsys-2Ddwc-2Darc-2Dprocessors_arc-5Fgnu-5Feclipse_blob_mast> er_com.arc.embeddedcdt_src_com_arc_embeddedcdt_gui_EmbeddedDebuggerTab> .java&d=DwIGaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=Evd3RDP3ozGDc0l3Ni8qnA1zQe2B> gvvQDPKNNUZqR2g&m=8iiigDh4_2r6P-mIlu36pFT2WKFbjWNTQ8ZPxSSmBdg&s=wR-4QR> VeHEFc3Ef8F9Gh0mZUeKK9212-GlOanHa4vy4&e=> .> Thank you,> Evgeniya>>>> _______________________________________________> cdt-dev mailing list> [hidden email]> To change your delivery options, retrieve your password, or > unsubscribe from this list, visit > https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_m> ailman_listinfo_cdt-2Ddev&d=DwIGaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=Evd3RDP3> ozGDc0l3Ni8qnA1zQe2BgvvQDPKNNUZqR2g&m=8iiigDh4_2r6P-mIlu36pFT2WKFbjWNT> Q8ZPxSSmBdg&s=Oj-ahC2iRXuowKEaQ8NkYnqqXUxb8AHpybw_PZmFV-s&e=_______________________________________________cdt-dev mailing [hidden email] change your delivery options, retrieve your password, or unsubscribe from this list, visit https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_cdt-2Ddev&d=DwIGaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=Evd3RDP3ozGDc0l3Ni8qnA1zQe2BgvvQDPKNNUZqR2g&m=8iiigDh4_2r6P-mIlu36pFT2WKFbjWNTQ8ZPxSSmBdg&s=Oj-ahC2iRXuowKEaQ8NkYnqqXUxb8AHpybw_PZmFV-s&e= _______________________________________________
> cdt-dev mailing list
> [hidden email]
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_cdt-2Ddev&d=DwIGaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=T2Nu5oC0cFpYft-aWVADZQwW1gKau7VGmdiLGLU-TEU&m=ppgsBK2wE2XhVxgjslVXSDkj9rXyZ0zxxOvopVAWg8U&s=d-YoltjtsszNQ_CX_cSJG3FdFqlw5rSsBv_vzCWi_fM&e=
> _______________________________________________
> cdt-dev mailing list
> [hidden email]
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/cdt-dev
_______________________________________________
cdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev