How to add a bundle to the aggregated build?

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

How to add a bundle to the aggregated build?

Karsten Thoms-3
We are using in an e4 RCP project the bundle org.eclipse.e4.ui.progress. The bundle is build with the platform-ui build. However, it is not part of the org.eclipse.e4.rcp feature by intention (see discussion in bug#559967) and is not part of the I-build repository. ATM we are building it ourselves, but would like to consume it from the official repositories.

My question is: Where needs the bundle to be added so that it will become part of the I-build repository?

~Karsten

_______________________________________________
platform-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev
Reply | Threaded
Open this post in threaded view
|

Re: How to add a bundle to the aggregated build?

Lars Vogel-2
Hi Karsten,

The original target of this view was to replace the E3 implementation. Once this is done, it would be part of e4.rcp

You and Paul updated it over the last year. What is missing to replace the old one?

Best regards, Lars

Karsten Thoms <[hidden email]> schrieb am Mi., 15. Apr. 2020, 17:02:
We are using in an e4 RCP project the bundle org.eclipse.e4.ui.progress. The bundle is build with the platform-ui build. However, it is not part of the org.eclipse.e4.rcp feature by intention (see discussion in bug#559967) and is not part of the I-build repository. ATM we are building it ourselves, but would like to consume it from the official repositories.

My question is: Where needs the bundle to be added so that it will become part of the I-build repository?

~Karsten
_______________________________________________
platform-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev

_______________________________________________
platform-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev
Reply | Threaded
Open this post in threaded view
|

Re: How to add a bundle to the aggregated build?

Mickael Istria-5
In reply to this post by Karsten Thoms-3
Hi Karsten,

Why is this bundle part of Platform source repo if it's not used anywhere in Platform?

Cheers


_______________________________________________
platform-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev
Reply | Threaded
Open this post in threaded view
|

Re: How to add a bundle to the aggregated build?

Karsten Thoms-3
In reply to this post by Lars Vogel-2
> Am 15.04.2020 um 17:05 schrieb Lars Vogel <[hidden email]>:
>
> The original target of this view was to replace the E3 implementation. Once this is done, it would be part of e4.rcp
>
> You and Paul updated it over the last year. What is missing to replace the old one?

I have fixed a bug and synchronized a bit of the implementations. The bundle works for our use case, but I can’t judge what is missing. The contents of package org.eclipse.ui.internal.progress contains more than the e4 bundle provides. As our use case is fulfilled I did not dig much further so far.

> Am 15.04.2020 um 17:05 schrieb Mickael Istria <[hidden email]>:
>
> Why is this bundle part of Platform source repo if it's not used anywhere in Platform?


Lars explained that hopefully. Hopefully we come to the situation some day to replace the old by the new one. If time permits I’ll analyze further how we can replace the old one.

For now, I need it just to be available in the repository without adding it to the rcp feature. Where should I have a look at?

_______________________________________________
platform-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev
Reply | Threaded
Open this post in threaded view
|

Re: How to add a bundle to the aggregated build?

Aleksandar Kurtakov


On Wed, Apr 15, 2020 at 10:39 PM Karsten Thoms <[hidden email]> wrote:
> Am 15.04.2020 um 17:05 schrieb Lars Vogel <[hidden email]>:
>
> The original target of this view was to replace the E3 implementation. Once this is done, it would be part of e4.rcp
>
> You and Paul updated it over the last year. What is missing to replace the old one?

I have fixed a bug and synchronized a bit of the implementations. The bundle works for our use case, but I can’t judge what is missing. The contents of package org.eclipse.ui.internal.progress contains more than the e4 bundle provides. As our use case is fulfilled I did not dig much further so far.

> Am 15.04.2020 um 17:05 schrieb Mickael Istria <[hidden email]>:
>
> Why is this bundle part of Platform source repo if it's not used anywhere in Platform?


Lars explained that hopefully. Hopefully we come to the situation some day to replace the old by the new one. If time permits I’ll analyze further how we can replace the old one.

For now, I need it just to be available in the repository without adding it to the rcp feature. Where should I have a look at?

Ideally it should be added to one of the features and that's it. Technical alternative is to list plugin in https://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/tree/eclipse.platform.releng.tychoeclipsebuilder/eclipse.platform.repository/category.xml directly but I don't remember this being done and I don't like setting thus precedense.
IMHO best is to add the plugin to e4.rcp feature.
 

_______________________________________________
platform-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev


--
Alexander Kurtakov
Red Hat Eclipse Team

_______________________________________________
platform-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev
Reply | Threaded
Open this post in threaded view
|

Re: How to add a bundle to the aggregated build?

Karsten Thoms-3

Am 15.04.2020 um 21:44 schrieb Aleksandar Kurtakov <[hidden email]>:
Ideally it should be added to one of the features and that's it. Technical alternative is to list plugin in https://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/tree/eclipse.platform.releng.tychoeclipsebuilder/eclipse.platform.repository/category.xml directly but I don't remember this being done and I don't like setting thus precedense. 
IMHO best is to add the plugin to e4.rcp feature.

That’s what I raised with https://bugs.eclipse.org/bugs/show_bug.cgi?id=559967 but Lars commented
> -1 for adding it to the e4.rcp feature. This feature is also used in the SDK.
> Include the org.eclipse.e4.ui.progress.feature in the build?
> +1, I assumed this bundle is part of the build
If there are no further objections I’ll provide a patch and further discussions could be done on the bug or the change.

I raised this discussion as I wanted to follow Lars’ recommendation but could not find how. Your hint answers now my question. We can decide now on the bug/change if that path has to be taken.

Thanks a lot to you all!

_______________________________________________
platform-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev