I need help building with a gson dependency

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

I need help building with a gson dependency

Wim Jongman-2
Hi,

I am facing a build problem in the ua repo for the tip of the day feature. I have a package dependency on google.gson but Tycho cannot find it for me. I have added the orbit repo that contains the gson bundle to the ua pom but that does not work.

I tried several things -> Adding gson bundle to a feature, use require bundle instead of package

Any suggestions on how this can be resolved?


Thanks,

Wim

  

_______________________________________________
platform-ui-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
Reply | Threaded
Open this post in threaded view
|

Re: I need help building with a gson dependency

Roland Grunberg
On Fri, Mar 2, 2018 at 11:00 AM, Wim Jongman <[hidden email]> wrote:

> I am facing a build problem in the ua repo for the tip of the day feature. I
> have a package dependency on google.gson but Tycho cannot find it for me. I
> have added the orbit repo that contains the gson bundle to the ua pom but
> that does not work.
>
> I tried several things -> Adding gson bundle to a feature, use require
> bundle instead of package
>
> Any suggestions on how this can be resolved?
>
> Gerrit change is: https://git.eclipse.org/r/118499
> Last build log is:
> https://ci.eclipse.org/platform/job/eclipse.platform.ua-Gerrit/505/consoleFull

It looks like you found the solution in the latest patchset. Tycho was
treating the
repository as a maven repository because of the missing <layout>p2</layout>.

I also just noticed, you replaced
https://ci.eclipse.org/orbit/job/orbit-recipes/lastSuccessfulBuild/artifact/releng/repository/target/repository
with an R-build which is what I would have recommended. Currently I think the
latest-R isn't pointing to the correct location which I can probably fix.

Cheers,
Roland Grunberg
_______________________________________________
platform-ui-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
Reply | Threaded
Open this post in threaded view
|

Re: I need help building with a gson dependency

Mickael Istria-5
In reply to this post by Wim Jongman-2
Hi Wim,

Allowed dependencies for Platform are not included in pom.xml. Instead, they're centralized in this file: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/tree/eclipse.platform.releng.prereqs.sdk/eclipse-sdk-prereqs.target . Please first make gson part of this .target and then your bundles will be allowed to consume it.

Cheers,

_______________________________________________
platform-ui-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
Reply | Threaded
Open this post in threaded view
|

Re: I need help building with a gson dependency

Wim Jongman-2
In reply to this post by Roland Grunberg
Thanks guys.

@Roland, I tried all combinations but no luck.

@Mickael, Does this require a CQ for gson and a gerrit for platform releng?

Cheers.

Wim

_______________________________________________
platform-ui-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
Reply | Threaded
Open this post in threaded view
|

Re: I need help building with a gson dependency

Mickael Istria-5


On Fri, Mar 2, 2018 at 9:40 PM, Wim Jongman <[hidden email]> wrote:
@Mickael, Does this require a CQ for gson and a gerrit for platform releng?

Yes.

_______________________________________________
platform-ui-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
Reply | Threaded
Open this post in threaded view
|

Re: I need help building with a gson dependency

Wim Jongman-2
In reply to this post by Wim Jongman-2
Oh wait, patch set 9 worked.

On Fri, Mar 2, 2018 at 9:40 PM, Wim Jongman <[hidden email]> wrote:
Thanks guys.

@Roland, I tried all combinations but no luck.

@Mickael, Does this require a CQ for gson and a gerrit for platform releng?

Cheers.

Wim


_______________________________________________
platform-ui-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
Reply | Threaded
Open this post in threaded view
|

Re: I need help building with a gson dependency

Wim Jongman-2
I have added the gson dependency to that file Mickael [1]. I cannot create a CQ because only committers can do that. What do you need from me to create that CQ?

Alternatively, we can _include_ minimal json [2] as a fat jar (33kb) inside this bundle. We would not need to change the global dependency file and you can create a piggyback CQ for minimal json.

Let me know what you think is best.

[1] https://git.eclipse.org/r/#/c/118574/
[2] https://dev.eclipse.org/ipzilla/show_bug.cgi?id=15783




On Fri, Mar 2, 2018 at 9:49 PM, Wim Jongman <[hidden email]> wrote:
Oh wait, patch set 9 worked.

On Fri, Mar 2, 2018 at 9:40 PM, Wim Jongman <[hidden email]> wrote:
Thanks guys.

@Roland, I tried all combinations but no luck.

@Mickael, Does this require a CQ for gson and a gerrit for platform releng?

Cheers.

Wim



_______________________________________________
platform-ui-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
Reply | Threaded
Open this post in threaded view
|

Re: I need help building with a gson dependency

Mickael Istria-5


On Sat, Mar 3, 2018 at 1:11 PM, Wim Jongman <[hidden email]> wrote:
I cannot create a CQ because only committers can do that. What do you need from me to create that CQ?

Your previous email was all that was needed. I opened https://dev.eclipse.org/ipzilla/show_bug.cgi?id=15807 (which is a piggyback CQ too)

Alternatively, we can _include_ minimal json [2] as a fat jar (33kb) inside this bundle. We would not need to change the global dependency file and you can create a piggyback CQ for minimal json.

See https://wiki.eclipse.org/SimRel/Simultaneous_Release_Requirements#Re-use_and_share_common_third_party_code_.28partially_tested.29 . This is against the rules of SimRel and against OSGi best practices, so Platform cannot use nested jars neither.

_______________________________________________
platform-ui-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev