Launch Groups

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Launch Groups

Duft Markus

Hey,

 

I have a change on Gerrit [1], which „fixes“ (implements) Bug 492788 [2] (“Proposal: Launch Groups”).

 

It essentially moves the launch groups implementation from CDT to platform.debug (with only little code changes). May I kindly ask for some review, as it is already around for some months :) Not sure whether a CQ is required – but if, it would be good to file it... I assume we do need one, as I had to restructure the code a little bit to split up the logic and the UI parts.

 

Thanks a lot in advance!

 

[1] https://git.eclipse.org/r/72511

[2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=492788

 

Cheers,

Markus

 

--

Mit freundlichen Grüßen / Best regards

 

Markus Duft | Software Architect

SSI SCHÄFER | Salomon Automation GmbH | Friesachstraße 15 | 8114 Friesach bei Graz | Austria

Phone +43 3127 200-575 | Fax +43 3127 200-22

[hidden email]

Website | Blog | YouTube | Facebook

 

Salomon Automation GmbH | Friesachstrasse 15 | 8114 Friesach bei Graz | Austria
Registered Office: Friesach bei Graz | Commercial Register: 49324 K | VAT no. ATU28654300
Commercial Court: Landesgericht für Zivilrechtssachen Graz

_______________________________________________
platform-debug-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-debug-dev
Reply | Threaded
Open this post in threaded view
|

Re: Launch Groups

Daniel Megert
Hi Markus

Yes, a CQ is needed. Sarika, please take care of this.

Thanks,
Dani



From:        Duft Markus <[hidden email]>
To:        "[hidden email]" <[hidden email]>
Date:        02.11.2016 15:18
Subject:        [platform-debug-dev] Launch Groups
Sent by:        [hidden email]




Hey,
 
I have a change on Gerrit [1], which „fixes“ (implements) Bug 492788 [2] (“Proposal: Launch Groups”).
 
It essentially moves the launch groups implementation from CDT to platform.debug (with only little code changes). May I kindly ask for some review, as it is already around for some months :) Not sure whether a CQ is required – but if, it would be good to file it... I assume we do need one, as I had to restructure the code a little bit to split up the logic and the UI parts.
 
Thanks a lot in advance!
 
[1] https://git.eclipse.org/r/72511
[2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=492788
 
Cheers,
Markus
 
--
Mit freundlichen Grüßen / Best regards
 
Markus Duft | Software Architect
SSI SCHÄFER | Salomon Automation GmbH | Friesachstraße 15 | 8114 Friesach bei Graz | Austria
Phone +43 3127 200-575 | Fax +43 3127 200-22
[hidden email]
Website| Blog| YouTube| Facebook
 

Salomon Automation GmbH | Friesachstrasse 15 | 8114 Friesach bei Graz | Austria
Registered Office: Friesach bei Graz | Commercial Register: 49324 K | VAT no. ATU28654300
Commercial Court: Landesgericht für Zivilrechtssachen Graz
_______________________________________________
platform-debug-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-debug-dev



_______________________________________________
platform-debug-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-debug-dev

Reply | Threaded
Open this post in threaded view
|

Re: Launch Groups

Jonah Graham
In reply to this post by Duft Markus
Hi Markus, Platform-debug,

When Bug 492788 was done, there was dicussion about moving Launch
Groups from CDT to Platform. AFAICT the new feature is in Platform
Debug (Yay!) but the CDT version was never removed. The result is that
when using CDT we have two Launch Group launch configuration types.

I have raised https://bugs.eclipse.org/bugs/show_bug.cgi?id=517722 to
cover removing the duplicate from CDT, but I would be very grateful if
someone who worked on this could summarise what has already been
figured out and add that info to Bug 517722. I have had a review of
Bug 492788, but at over 80 comments a summary would be useful.

Thanks,
Jonah
~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com


On 2 November 2016 at 14:18, Duft Markus <[hidden email]> wrote:

> Hey,
>
>
>
> I have a change on Gerrit [1], which „fixes“ (implements) Bug 492788 [2]
> (“Proposal: Launch Groups”).
>
>
>
> It essentially moves the launch groups implementation from CDT to
> platform.debug (with only little code changes). May I kindly ask for some
> review, as it is already around for some months :) Not sure whether a CQ is
> required – but if, it would be good to file it... I assume we do need one,
> as I had to restructure the code a little bit to split up the logic and the
> UI parts.
>
>
>
> Thanks a lot in advance!
>
>
>
> [1] https://git.eclipse.org/r/72511
>
> [2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=492788
>
>
>
> Cheers,
>
> Markus
>
>
>
> --
>
> Mit freundlichen Grüßen / Best regards
>
>
>
> Markus Duft | Software Architect
>
> SSI SCHÄFER | Salomon Automation GmbH | Friesachstraße 15 | 8114 Friesach
> bei Graz | Austria
>
> Phone +43 3127 200-575 | Fax +43 3127 200-22
>
> [hidden email]
>
> Website | Blog | YouTube | Facebook
>
>
>
> Salomon Automation GmbH | Friesachstrasse 15 | 8114 Friesach bei Graz |
> Austria
> Registered Office: Friesach bei Graz | Commercial Register: 49324 K | VAT
> no. ATU28654300
> Commercial Court: Landesgericht für Zivilrechtssachen Graz
>
> _______________________________________________
> platform-debug-dev mailing list
> [hidden email]
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/platform-debug-dev
_______________________________________________
platform-debug-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-debug-dev