Merging GitHub pull requests

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Merging GitHub pull requests

Madura Anushanga
Hi,
I have added a PR[1] for adding support for newer MSVC versions with CDT, it has been on github eclipse repo for a long time without being rejected or merged. Please comment.

1. https://github.com/eclipse/cdt/pull/7/commits

            - Madura A.

_______________________________________________
cdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Merging GitHub pull requests

Jonah Graham
Hi Madura,

Unfortunately the github CDT is just a mirror of
git://git.eclipse.org/gitroot/cdt/org.eclipse.cdt.git

Please submit this to gerrit https://wiki.eclipse.org/CDT/contributing
& https://wiki.eclipse.org/CDT/git#Using_Gerrit_for_CDT and I will
have a review.

As a preliminary review, please consider the error handling in your
new code. In particular this code block

+ } catch (Exception e) {
+ // TODO Auto-generated catch block
+ e.printStackTrace();
+ }

I will need steps to reproduce the problem too, so that I can test the change.


I have raised https://bugs.eclipse.org/bugs/show_bug.cgi?id=520800 to
address that PRs on GitHub look like an ok place to submit to.

Thanks,
Jonah
~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com


On 10 August 2017 at 07:52, Madura Anushanga <[hidden email]> wrote:

> Hi,
> I have added a PR[1] for adding support for newer MSVC versions with CDT, it
> has been on github eclipse repo for a long time without being rejected or
> merged. Please comment.
>
> 1. https://github.com/eclipse/cdt/pull/7/commits
>
>             - Madura A.
>
> _______________________________________________
> cdt-dev mailing list
> [hidden email]
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/cdt-dev
_______________________________________________
cdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev
Loading...