NPE on Eclipse JDT Core

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

NPE on Eclipse JDT Core

George Gastaldi-2
Hey! 

I work on Roaster - a Java parser using JDT [1] and I found a NPE bug preventing me from parsing JDK 14 Records (when enabling the preview features).

I have provided the fix in [2] but I am not sure if that repository is just a mirror or is the official repository (the link in [3] only states to ping the mailing list).


Best Regards,

George Gastaldi



_______________________________________________
jdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: NPE on Eclipse JDT Core

Gayan Perera
Hi George,

Please provide a gerrit patch to JDT code. project and gerrit urls are mentioned in https://projects.eclipse.org/projects/eclipse.jdt/developer.
Also please report a bug in http://bugs.eclipse.org/ for this and mention the bug id in the comment, thats mandatory.

Best regards,
Gayan.

On Sat, Sep 5, 2020 at 8:06 PM George Gastaldi <[hidden email]> wrote:
Hey! 

I work on Roaster - a Java parser using JDT [1] and I found a NPE bug preventing me from parsing JDK 14 Records (when enabling the preview features).

I have provided the fix in [2] but I am not sure if that repository is just a mirror or is the official repository (the link in [3] only states to ping the mailing list).


Best Regards,

George Gastaldi


_______________________________________________
jdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jdt-dev

_______________________________________________
jdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: NPE on Eclipse JDT Core

George Gastaldi-2
Thanks Gayan!

This is the first time I ever used Gerrit, so I am not sure if I did it correctly: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/168865
Can you have a look at it?

Thank you once again

Em sáb., 5 de set. de 2020 às 16:00, Gayan Perera <[hidden email]> escreveu:
Hi George,

Please provide a gerrit patch to JDT code. project and gerrit urls are mentioned in https://projects.eclipse.org/projects/eclipse.jdt/developer.
Also please report a bug in http://bugs.eclipse.org/ for this and mention the bug id in the comment, thats mandatory.

Best regards,
Gayan.

On Sat, Sep 5, 2020 at 8:06 PM George Gastaldi <[hidden email]> wrote:
Hey! 

I work on Roaster - a Java parser using JDT [1] and I found a NPE bug preventing me from parsing JDK 14 Records (when enabling the preview features).

I have provided the fix in [2] but I am not sure if that repository is just a mirror or is the official repository (the link in [3] only states to ping the mailing list).


Best Regards,

George Gastaldi


_______________________________________________
jdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jdt-dev
_______________________________________________
jdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jdt-dev

_______________________________________________
jdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: NPE on Eclipse JDT Core

Gayan Perera
Hi Geoge,

Thanks for the patch and it looks good, nothing is missing that supposed to be there according to my knowledge. I don't have much experience in jdt core, because i have only contributed to jdt debug. But i think definitely you need to add a unit test for this fix as well. But let's wait for reviewers' feedback.

Best regards,
Gayan.

On Sun, Sep 6, 2020 at 3:26 AM George Gastaldi <[hidden email]> wrote:
Thanks Gayan!

This is the first time I ever used Gerrit, so I am not sure if I did it correctly: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/168865
Can you have a look at it?

Thank you once again

Em sáb., 5 de set. de 2020 às 16:00, Gayan Perera <[hidden email]> escreveu:
Hi George,

Please provide a gerrit patch to JDT code. project and gerrit urls are mentioned in https://projects.eclipse.org/projects/eclipse.jdt/developer.
Also please report a bug in http://bugs.eclipse.org/ for this and mention the bug id in the comment, thats mandatory.

Best regards,
Gayan.

On Sat, Sep 5, 2020 at 8:06 PM George Gastaldi <[hidden email]> wrote:
Hey! 

I work on Roaster - a Java parser using JDT [1] and I found a NPE bug preventing me from parsing JDK 14 Records (when enabling the preview features).

I have provided the fix in [2] but I am not sure if that repository is just a mirror or is the official repository (the link in [3] only states to ping the mailing list).


Best Regards,

George Gastaldi


_______________________________________________
jdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jdt-dev
_______________________________________________
jdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jdt-dev
_______________________________________________
jdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jdt-dev

_______________________________________________
jdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: NPE on Eclipse JDT Core

Manoj Palat-2
Thanks Geoge for the patch - and thanks Gayan for guiding Geoge.
I've added Sarika.Sinha as the reviewer for this dom.ast issue.


Regards,
Manoj

-----[hidden email] wrote: -----
To: "Eclipse JDT general developers list." <[hidden email]>
From: Gayan Perera
Sent by: [hidden email]
Date: 09/06/2020 03:08PM
Subject: [EXTERNAL] Re: [jdt-dev] NPE on Eclipse JDT Core

Hi Geoge,

Thanks for the patch and it looks good, nothing is missing that supposed to be there according to my knowledge. I don't have much experience in jdt core, because i have only contributed to jdt debug. But i think definitely you need to add a unit test for this fix as well. But let's wait for reviewers' feedback.

Best regards,
Gayan.
On Sun, Sep 6, 2020 at 3:26 AM George Gastaldi <[hidden email]> wrote:
Thanks Gayan!

This is the first time I ever used Gerrit, so I am not sure if I did it correctly: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/168865
Can you have a look at it?

Thank you once again
Em sáb., 5 de set. de 2020 às 16:00, Gayan Perera <[hidden email]> escreveu:
Hi George,

Please provide a gerrit patch to JDT code. project and gerrit urls are mentioned in https://projects.eclipse.org/projects/eclipse.jdt/developer.
Also please report a bug in http://bugs.eclipse.org/ for this and mention the bug id in the comment, thats mandatory.

Best regards,
Gayan.
On Sat, Sep 5, 2020 at 8:06 PM George Gastaldi <[hidden email]> wrote:
Hey!

I work on Roaster - a Java parser using JDT [1] and I found a NPE bug preventing me from parsing JDK 14 Records (when enabling the preview features).

I have provided the fix in [2] but I am not sure if that repository is just a mirror or is the official repository (the link in [3] only states to ping the mailing list).


Best Regards,

George Gastaldi


[1] - https://github.com/forge/roaster
[2] - https://github.com/eclipse/eclipse.jdt.core/pull/60
[3] - https://www.eclipse.org/jdt/core/index.php#DEV _______________________________________________
jdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jdt-dev
_______________________________________________
jdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jdt-dev
_______________________________________________
jdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jdt-dev

_______________________________________________
jdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jdt-dev

_______________________________________________
jdt-dev mailing list
[hidden email]
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jdt-dev