Need help with a review

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Need help with a review

Mickael Istria-5
Hi all,

There's a patch about generic (basically replacing an Object type parameter by a ? one): https://git.eclipse.org/r/#/c/72573/3 . I did review it, and it *seems* fine *to me* to merge it in master because I believe it's backward compatible, but I have to admit I don't feel confident enough with such things about generic to rely only on my opinion and merge it.
So if anyone who feel well with generics can have a look and take over the review, that'd be highly welcome!

Thanks in advance,
--
Mickael Istria
Eclipse IDE developer, at Red Hat Developers community
Elected Committer Representative at the Eclipse Foundation board of directors

_______________________________________________
platform-ui-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
Reply | Threaded
Open this post in threaded view
|

Re: Need help with a review

Daniel Megert
Done.

Dani



From:        Mickael Istria <[hidden email]>
To:        "Eclipse Platform UI component developers list." <[hidden email]>
Date:        20.11.2017 11:49
Subject:        [platform-ui-dev] Need help with a review
Sent by:        [hidden email]




Hi all,

There's a patch about generic (basically replacing an Object type parameter by a ? one): https://git.eclipse.org/r/#/c/72573/3. I did review it, and it *seems* fine *to me* to merge it in master because I believe it's backward compatible, but I have to admit I don't feel confident enough with such things about generic to rely only on my opinion and merge it.
So if anyone who feel well with generics can have a look and take over the review, that'd be highly welcome!

Thanks in advance,
--
Mickael Istria
Eclipse IDE developer, at Red Hat Developers community
Elected Committer Representative at the Eclipse Foundation board of directors_______________________________________________
platform-ui-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_platform-2Dui-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=aOqTlfYo9sOVaVcpFTjAexJhn2bYLSMsaNR6Gwj7v9s&s=mWb_GFgayv_8UgqwgpjSgAIj6gONRzVOwQNWn_sIt3c&e=



_______________________________________________
platform-ui-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev