Patches for review

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Patches for review

Conrad Groth

I provided some patches for the SWT win32 implementation, that can be reviewed:

https://git.eclipse.org/r/#/c/87547/

https://git.eclipse.org/r/#/c/99533/

https://git.eclipse.org/r/#/c/100005/

https://git.eclipse.org/r/#/c/105655/

 

The first one is waiting for review for 8 months now :(

And it improves the dark theme on Windows.


_______________________________________________
platform-swt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-swt-dev
Reply | Threaded
Open this post in threaded view
|

Re: Patches for review

Ned Twigg
Thanks Conrad, these look great!!

Ned Twigg
Lead Software Architect, DiffPlug LLC
540-336-8043 (cell)
888-513-6870 (fax)
340 S Lemon Ave #343
3, Walnut, CA 91789

On Wed, Sep 27, 2017 at 1:40 PM, Conrad Groth <[hidden email]> wrote:

I provided some patches for the SWT win32 implementation, that can be reviewed:

https://git.eclipse.org/r/#/c/87547/

https://git.eclipse.org/r/#/c/99533/

https://git.eclipse.org/r/#/c/100005/

https://git.eclipse.org/r/#/c/105655/

 

The first one is waiting for review for 8 months now :(

And it improves the dark theme on Windows.


_______________________________________________
platform-swt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-swt-dev


_______________________________________________
platform-swt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-swt-dev
Reply | Threaded
Open this post in threaded view
|

Re: Patches for review

Thomas Singer
In reply to this post by Conrad Groth
Hi Conrad,

Thank you for your contributions.

> The first one is waiting for review for 8 months now

I know similar behavior from other open source projects (e.g. JGit) and
I think, this is very discouraging for the contributors. Please review
in reasonable time and either accept or reject it with a useful explanation.

--
Best regards,
Thomas Singer
=============
syntevo GmbH
http://www.syntevo.com
http://www.syntevo.com/blog


On 27.09.2017 22:40, Conrad Groth wrote:

> I provided some patches for the SWT win32 implementation, that can be
> reviewed:
>
>   <https://git.eclipse.org/r/#/c/87547/> https://git.eclipse.org/r/#/c/87547/
>
> https://git.eclipse.org/r/#/c/99533/
>
> https://git.eclipse.org/r/#/c/100005/
>
> https://git.eclipse.org/r/#/c/105655/
>
>  
>
> The first one is waiting for review for 8 months now :(
>
> And it improves the dark theme on Windows.
>
>
>
>
> _______________________________________________
> platform-swt-dev mailing list
> [hidden email]
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/platform-swt-dev
>
_______________________________________________
platform-swt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-swt-dev
Reply | Threaded
Open this post in threaded view
|

Re: Patches for review

Aleksandar Kurtakov
On Thu, Sep 28, 2017 at 10:05 AM, Thomas Singer <[hidden email]> wrote:

> Hi Conrad,
>
> Thank you for your contributions.
>
>> The first one is waiting for review for 8 months now
>
>
> I know similar behavior from other open source projects (e.g. JGit) and I
> think, this is very discouraging for the contributors. Please review in
> reasonable time and either accept or reject it with a useful explanation.

I'm really sorry to hear such experience with one of the Platform
projects as personally I strive to change that as it's IMHO the most
important thing. Not to have current committers implement many cool
features, not to have timely reply on bugs but to review proposed
patches and grow some people to committers so we can work on the first
2 things together.
Niraj, as you're the win32 person, can we have these patches
prioritized? It would be nice to spend some time with Conrad and make
him a committer to unblock the win32 which can not progress as long as
you're the only person.
P.S. I would dare to say that this is not representative for SWT
project as a whole as e.g. the GTK specific patches are reviewed in
timely manner (down to zero unattended patches for this port, although
there are some in the queue just needing more work). Due to the
specific of the project it is impossible to review patches for WS one
has no idea for or even haven't seen it in years.

>
> --
> Best regards,
> Thomas Singer
> =============
> syntevo GmbH
> http://www.syntevo.com
> http://www.syntevo.com/blog
>
>
> On 27.09.2017 22:40, Conrad Groth wrote:
>>
>> I provided some patches for the SWT win32 implementation, that can be
>> reviewed:
>>
>>   <https://git.eclipse.org/r/#/c/87547/>
>> https://git.eclipse.org/r/#/c/87547/
>>
>> https://git.eclipse.org/r/#/c/99533/
>>
>> https://git.eclipse.org/r/#/c/100005/
>>
>> https://git.eclipse.org/r/#/c/105655/
>>
>>
>> The first one is waiting for review for 8 months now :(
>>
>> And it improves the dark theme on Windows.
>>
>>
>>
>>
>> _______________________________________________
>> platform-swt-dev mailing list
>> [hidden email]
>> To change your delivery options, retrieve your password, or unsubscribe
>> from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/platform-swt-dev
>>
> _______________________________________________
> platform-swt-dev mailing list
> [hidden email]
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/platform-swt-dev



--
Alexander Kurtakov
Red Hat Eclipse Team
_______________________________________________
platform-swt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-swt-dev
Reply | Threaded
Open this post in threaded view
|

Re: Patches for review

Niraj Modi
Hi Conrad,

Thanks for your contributions to the Windows port.

All of the mentioned gerrit patches already have comments either on bugzilla or gerrit:
Specifically:
https://git.eclipse.org/r/#/c/87547/
- As clearly mentioned in the bug, we decided not to take it up in Oxygen due to the nature of the changes involved and was postponed for Photon. I’ll review it shortly.

https://git.eclipse.org/r/#/c/105655/
- This is a very recent patch, under my radar

Other two patches are already under review as you can see in the bug comments and going through verification.

SWT team always welcomes external contributions. The reason for any delay in merging the patches (especially the custom drawing ones) is because they need to be thoroughly tested for various possible use cases (positive as well as possible breakages) and on different platforms. If this part is already done, it would lead to a quick review cycle. We welcome any help in testing the gerrit patches from the community as well.

Please note that the priority and severity of the bug relative to other SWT/win32 bugs should also be considered.

Thanks!

Regards,
Niraj Modi


From:        Aleksandar Kurtakov <[hidden email]>
To:        "Eclipse Platform SWT component developers list." <[hidden email]>
Date:        09/28/2017 12:56 PM
Subject:        Re: [platform-swt-dev] Patches for review
Sent by:        [hidden email]




On Thu, Sep 28, 2017 at 10:05 AM, Thomas Singer <[hidden email]> wrote:

> Hi Conrad,
>
> Thank you for your contributions.
>
>> The first one is waiting for review for 8 months now
>
>
> I know similar behavior from other open source projects (e.g. JGit) and I
> think, this is very discouraging for the contributors. Please review in
> reasonable time and either accept or reject it with a useful explanation.

I'm really sorry to hear such experience with one of the Platform
projects as personally I strive to change that as it's IMHO the most
important thing. Not to have current committers implement many cool
features, not to have timely reply on bugs but to review proposed
patches and grow some people to committers so we can work on the first
2 things together.
Niraj, as you're the win32 person, can we have these patches
prioritized? It would be nice to spend some time with Conrad and make
him a committer to unblock the win32 which can not progress as long as
you're the only person.
P.S. I would dare to say that this is not representative for SWT
project as a whole as e.g. the GTK specific patches are reviewed in
timely manner (down to zero unattended patches for this port, although
there are some in the queue just needing more work). Due to the
specific of the project it is impossible to review patches for WS one
has no idea for or even haven't seen it in years.

>
> --
> Best regards,
> Thomas Singer
> =============
> syntevo GmbH
>
https://urldefense.proofpoint.com/v2/url?u=http-3A__www.syntevo.com&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=_TZ5U2NJh9lXkaj4_qKbwIbEVB6nLCFcKlW-Qi4EQTE&m=z753KZgcmHyxNiz_DkNkpxRjQIpX0YNlMOvt1dnYjCM&s=hdCmVq2rNDyGQU3azGJ61MU-zxFlVDnTpg4XTAHSruE&e=
>
https://urldefense.proofpoint.com/v2/url?u=http-3A__www.syntevo.com_blog&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=_TZ5U2NJh9lXkaj4_qKbwIbEVB6nLCFcKlW-Qi4EQTE&m=z753KZgcmHyxNiz_DkNkpxRjQIpX0YNlMOvt1dnYjCM&s=8mhYGLneTBA7JhDrjdco7E6TOuwxUWAlp4HlGQTl-FE&e=
>
>
> On 27.09.2017 22:40, Conrad Groth wrote:
>>
>> I provided some patches for the SWT win32 implementation, that can be
>> reviewed:
>>
>>   <
https://urldefense.proofpoint.com/v2/url?u=https-3A__git.eclipse.org_r_-23_c_87547_&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=_TZ5U2NJh9lXkaj4_qKbwIbEVB6nLCFcKlW-Qi4EQTE&m=z753KZgcmHyxNiz_DkNkpxRjQIpX0YNlMOvt1dnYjCM&s=G2nrBoXHHcOVkEEAgeRAVJ03uwtgy8ss2k2ZZpqq3cs&e=>
>>
https://urldefense.proofpoint.com/v2/url?u=https-3A__git.eclipse.org_r_-23_c_87547_&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=_TZ5U2NJh9lXkaj4_qKbwIbEVB6nLCFcKlW-Qi4EQTE&m=z753KZgcmHyxNiz_DkNkpxRjQIpX0YNlMOvt1dnYjCM&s=G2nrBoXHHcOVkEEAgeRAVJ03uwtgy8ss2k2ZZpqq3cs&e=
>>
>>
https://urldefense.proofpoint.com/v2/url?u=https-3A__git.eclipse.org_r_-23_c_99533_&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=_TZ5U2NJh9lXkaj4_qKbwIbEVB6nLCFcKlW-Qi4EQTE&m=z753KZgcmHyxNiz_DkNkpxRjQIpX0YNlMOvt1dnYjCM&s=o6iTFYA6nwi_zAj994_ESIIogaJWXeoZ4JaTjHmK6zk&e=
>>
>>
https://urldefense.proofpoint.com/v2/url?u=https-3A__git.eclipse.org_r_-23_c_100005_&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=_TZ5U2NJh9lXkaj4_qKbwIbEVB6nLCFcKlW-Qi4EQTE&m=z753KZgcmHyxNiz_DkNkpxRjQIpX0YNlMOvt1dnYjCM&s=-T-9c3Lpg07QdAgHmXfBD8fsamCpWB1ZbF5lNvGhZiU&e=
>>
>>
https://urldefense.proofpoint.com/v2/url?u=https-3A__git.eclipse.org_r_-23_c_105655_&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=_TZ5U2NJh9lXkaj4_qKbwIbEVB6nLCFcKlW-Qi4EQTE&m=z753KZgcmHyxNiz_DkNkpxRjQIpX0YNlMOvt1dnYjCM&s=sMNr9d6Y0roRfSYwSdMXf4W1qq96KtFaNzxTLweRjBw&e=
>>
>>
>> The first one is waiting for review for 8 months now :(
>>
>> And it improves the dark theme on Windows.
>>
>>
>>
>>
>> _______________________________________________
>> platform-swt-dev mailing list
>> [hidden email]
>> To change your delivery options, retrieve your password, or unsubscribe
>> from this list, visit
>>
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_platform-2Dswt-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=_TZ5U2NJh9lXkaj4_qKbwIbEVB6nLCFcKlW-Qi4EQTE&m=z753KZgcmHyxNiz_DkNkpxRjQIpX0YNlMOvt1dnYjCM&s=2CXIzXAu4mVfdPDSjp7vQl_Qt3FXI7J3VnOOR7dp_PA&e=
>>
> _______________________________________________
> platform-swt-dev mailing list
> [hidden email]
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
>
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_platform-2Dswt-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=_TZ5U2NJh9lXkaj4_qKbwIbEVB6nLCFcKlW-Qi4EQTE&m=z753KZgcmHyxNiz_DkNkpxRjQIpX0YNlMOvt1dnYjCM&s=2CXIzXAu4mVfdPDSjp7vQl_Qt3FXI7J3VnOOR7dp_PA&e=



--
Alexander Kurtakov
Red Hat Eclipse Team
_______________________________________________
platform-swt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_platform-2Dswt-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=_TZ5U2NJh9lXkaj4_qKbwIbEVB6nLCFcKlW-Qi4EQTE&m=z753KZgcmHyxNiz_DkNkpxRjQIpX0YNlMOvt1dnYjCM&s=2CXIzXAu4mVfdPDSjp7vQl_Qt3FXI7J3VnOOR7dp_PA&e=





_______________________________________________
platform-swt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-swt-dev