Re: Adding @Override to the plug-ins in JDT core via https://git.eclipse.org/r/#/c/97434/ from Andrey

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Adding @Override to the plug-ins in JDT core via https://git.eclipse.org/r/#/c/97434/ from Andrey

Jayaprakash Arthanareeswaran
Hi Lars,
 
Sure, we will take this forward.
 
Thanks for the reminder.
 
Jay
 
----- Original message -----
From: Lars Vogel <[hidden email]>
Sent by: [hidden email]
To: "Eclipse JDT general developers list." <[hidden email]>
Cc:
Subject: [jdt-dev] Adding @Override to the plug-ins in JDT core via https://git.eclipse.org/r/#/c/97434/ from Andrey
Date: Wed, Nov 15, 2017 4:42 PM
 
Hi JDT devs,

a while ago, it was said that https://urldefense.proofpoint.com/v2/url?u=https-3A__git.eclipse.org_r_-23_c_97434_&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=LuMqcl3PU0i2olgTvkVvFthzqyc_3wGfGooplpAvFsc&m=5rOaczeI4qZObVuyjZB3JEqQoXwTG29VV5qPtijAaWA&s=wvkKguUozLrbzZpCs1hUZFuX3L7yO5lq7FGM-8bBxmE&e=
(which adds missing @Overrides) could not be merged because Java 9 was
developed in a separate branch and this would create so much noise.

Can you now merge this? Or run the @Override cleanup action yourself
for the repo. I get lots of Sonar warnings if I look at the code
without this..

These annotations would have help with Bug 506009 which would improve
the  IDE performance. See the discussion at
https://urldefense.proofpoint.com/v2/url?u=https-3A__git.eclipse.org_r_-23_c_83269_&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=LuMqcl3PU0i2olgTvkVvFthzqyc_3wGfGooplpAvFsc&m=5rOaczeI4qZObVuyjZB3JEqQoXwTG29VV5qPtijAaWA&s=Zmc5uRuy1qG8v71sq7z_6CqkC4KqdTBMq40HsaZqIDg&e=.

Best regards, Lars

--
Eclipse Platform project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: [hidden email], Web: https://urldefense.proofpoint.com/v2/url?u=http-3A__www.vogella.com&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=LuMqcl3PU0i2olgTvkVvFthzqyc_3wGfGooplpAvFsc&m=5rOaczeI4qZObVuyjZB3JEqQoXwTG29VV5qPtijAaWA&s=yc1Bj2YeB-mNA8K4BBPgZQ-vgyU88pYYQ9GeFDjylvw&e=
_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_jdt-2Ddev&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=LuMqcl3PU0i2olgTvkVvFthzqyc_3wGfGooplpAvFsc&m=5rOaczeI4qZObVuyjZB3JEqQoXwTG29VV5qPtijAaWA&s=Qh_YbkawcrzposgnuqOBc_qeTRUq4jY5Nf1mEHBuH20&e=
 


_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: Adding @Override to the plug-ins in JDT core via https://git.eclipse.org/r/#/c/97434/ from Andrey

Lars Vogel-2
Thanks, Jay.

On Wed, Nov 15, 2017 at 12:22 PM, Jayaprakash Arthanareeswaran
<[hidden email]> wrote:

> Hi Lars,
>
> Sure, we will take this forward.
>
> Thanks for the reminder.
>
> Jay
>
>
> ----- Original message -----
> From: Lars Vogel <[hidden email]>
> Sent by: [hidden email]
> To: "Eclipse JDT general developers list." <[hidden email]>
> Cc:
> Subject: [jdt-dev] Adding @Override to the plug-ins in JDT core via
> https://git.eclipse.org/r/#/c/97434/ from Andrey
> Date: Wed, Nov 15, 2017 4:42 PM
>
> Hi JDT devs,
>
> a while ago, it was said that
> https://urldefense.proofpoint.com/v2/url?u=https-3A__git.eclipse.org_r_-23_c_97434_&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=LuMqcl3PU0i2olgTvkVvFthzqyc_3wGfGooplpAvFsc&m=5rOaczeI4qZObVuyjZB3JEqQoXwTG29VV5qPtijAaWA&s=wvkKguUozLrbzZpCs1hUZFuX3L7yO5lq7FGM-8bBxmE&e=
> (which adds missing @Overrides) could not be merged because Java 9 was
> developed in a separate branch and this would create so much noise.
>
> Can you now merge this? Or run the @Override cleanup action yourself
> for the repo. I get lots of Sonar warnings if I look at the code
> without this..
>
> These annotations would have help with Bug 506009 which would improve
> the  IDE performance. See the discussion at
> https://urldefense.proofpoint.com/v2/url?u=https-3A__git.eclipse.org_r_-23_c_83269_&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=LuMqcl3PU0i2olgTvkVvFthzqyc_3wGfGooplpAvFsc&m=5rOaczeI4qZObVuyjZB3JEqQoXwTG29VV5qPtijAaWA&s=Zmc5uRuy1qG8v71sq7z_6CqkC4KqdTBMq40HsaZqIDg&e=.
>
> Best regards, Lars
>
> --
> Eclipse Platform project co-lead
> CEO vogella GmbH
>
> Haindaalwisch 17a, 22395 Hamburg
> Amtsgericht Hamburg: HRB 127058
> Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
> USt-IdNr.: DE284122352
> Fax (040) 5247 6322, Email: [hidden email], Web:
> https://urldefense.proofpoint.com/v2/url?u=http-3A__www.vogella.com&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=LuMqcl3PU0i2olgTvkVvFthzqyc_3wGfGooplpAvFsc&m=5rOaczeI4qZObVuyjZB3JEqQoXwTG29VV5qPtijAaWA&s=yc1Bj2YeB-mNA8K4BBPgZQ-vgyU88pYYQ9GeFDjylvw&e=
> _______________________________________________
> jdt-dev mailing list
> [hidden email]
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_jdt-2Ddev&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=LuMqcl3PU0i2olgTvkVvFthzqyc_3wGfGooplpAvFsc&m=5rOaczeI4qZObVuyjZB3JEqQoXwTG29VV5qPtijAaWA&s=Qh_YbkawcrzposgnuqOBc_qeTRUq4jY5Nf1mEHBuH20&e=
>
>
>
>
> _______________________________________________
> jdt-dev mailing list
> [hidden email]
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/jdt-dev



--
Eclipse Platform project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: [hidden email], Web: http://www.vogella.com
_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jdt-dev