Re: [eclipse-dev] Moving JDT's LTK bundles toeclipse.platform.text?

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [eclipse-dev] Moving JDT's LTK bundles toeclipse.platform.text?

Daniel Megert
Here is a very simple and obvious example: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/tree/org.eclipse.ltk.core.refactoring/pom.xml

A Gerrit change is against a repository. If the changed project is moved, the Gerrit change won't work anymore (unless it gets fixed, as mentioned in my message).

Dani



From:        Mickael Istria <[hidden email]>
To:        "Eclipse JDT general developers list." <[hidden email]>
Cc:        "General development mailing list of the Eclipse project." <[hidden email]>, [hidden email]
Date:        09.11.2017 15:00
Subject:        Re: [eclipse-dev] [jdt-dev] Moving JDT's LTK bundles to        eclipse.platform.text?
Sent by:        [hidden email]






On Thu, Nov 9, 2017 at 12:22 PM, Daniel Megert <daniel_megert@...> wrote:
My concern is that it will invalidate existing links and Gerrit changes. If they can be forwarded/adjusted to the new location, I would be fine to try it.

I'm not sure I fully understand which kind of links and invalid state you're talking about. I also don't get the issue with Gerrit changes.
Can you please provide examples of such links (and tell where they come from)?_______________________________________________
eclipse-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_eclipse-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=PirKZEt7Pu7okjSHT33UYB3NuWsL7MoEBryMdPZMa2c&s=ABHyramfSFvcIAX5banLqr9eKfM4WiRrMl6nRJQiF7I&e=



_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: [eclipse-dev] Moving JDT's LTK bundles toeclipse.platform.text?

Lars Vogel-2
If we have open Gerrits for the LTK bundles, they can be recreated for
the new repo.

I had a quick look at the open reviews for JDT UI and could not find a
lot in general and nothing in particular for  LTK. I volunteer to move
any LTK open Gerrit to a new repo if necessary.

On Thu, Nov 9, 2017 at 3:13 PM, Daniel Megert <[hidden email]> wrote:

> Here is a very simple and obvious example:
> http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/tree/org.eclipse.ltk.core.refactoring/pom.xml
>
> A Gerrit change is against a repository. If the changed project is moved,
> the Gerrit change won't work anymore (unless it gets fixed, as mentioned in
> my message).
>
> Dani
>
>
>
> From:        Mickael Istria <[hidden email]>
> To:        "Eclipse JDT general developers list." <[hidden email]>
> Cc:        "General development mailing list of the Eclipse project."
> <[hidden email]>, [hidden email]
> Date:        09.11.2017 15:00
> Subject:        Re: [eclipse-dev] [jdt-dev] Moving JDT's LTK bundles to
> eclipse.platform.text?
> Sent by:        [hidden email]
> ________________________________
>
>
>
>
>
> On Thu, Nov 9, 2017 at 12:22 PM, Daniel Megert <[hidden email]>
> wrote:
> My concern is that it will invalidate existing links and Gerrit changes. If
> they can be forwarded/adjusted to the new location, I would be fine to try
> it.
>
> I'm not sure I fully understand which kind of links and invalid state you're
> talking about. I also don't get the issue with Gerrit changes.
> Can you please provide examples of such links (and tell where they come
> from)?_______________________________________________
> eclipse-dev mailing list
> [hidden email]
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_eclipse-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=PirKZEt7Pu7okjSHT33UYB3NuWsL7MoEBryMdPZMa2c&s=ABHyramfSFvcIAX5banLqr9eKfM4WiRrMl6nRJQiF7I&e=
>
>
>
> _______________________________________________
> jdt-dev mailing list
> [hidden email]
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/jdt-dev



--
Eclipse Platform project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: [hidden email], Web: http://www.vogella.com
_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: [eclipse-dev] Moving JDT's LTK bundlestoeclipse.platform.text?

Lars Vogel-2
In reply to this post by Daniel Megert
> Because it affects tons of files. It would be good to have a redirect in place.

Definitely possible to do a URI redirect but I think webmaster needed
to do that. For example, on vogella.com we use a lot of URL rewrites
for our Apache HTTP server, examples below:

    RewriteEngine On
    RewriteCond %{HTTP_HOST}
^(www.vogella.net|vogella.net|www.vogella.org|vogella.org|www.vogella.de|vogella.de)
[NC]
    RewriteRule ^(.*)$ http://www.vogella.com$1 [R=301,L]

    RewriteEngine on
    RewriteCond %{HTTP_HOST} ^training\.vogella\.com$ [NC]
    RewriteRule ^(.*)$ http://www.vogella.com/training$1 [R=301,L]

    RewriteEngine on
    RewriteRule   ^/articles/(.+)  http://www.vogella.com/tutorials/$1
 [R=301,L]


    RewriteEngine on
    RewriteRule   ^/code/(.+)/(.+)
http://www.vogella.com/code/index.html  [R=301,L]


On Thu, Nov 9, 2017 at 3:29 PM, Daniel Megert <[hidden email]> wrote:
>> Indeed, moved content won't be available any more. But I don't get why
>> this is more an issue than removing any other file in a Git repo. What makes
>> it a possible blocker here?
>

>
> Dani
>
>
>
> From:        Mickael Istria <[hidden email]>
> To:        "Eclipse JDT general developers list." <[hidden email]>
> Cc:        "General development mailing list of the Eclipse project."
> <[hidden email]>, [hidden email],
> [hidden email]
> Date:        09.11.2017 15:25
> Subject:        Re: [eclipse-dev] [jdt-dev] Moving JDT's LTK bundles
> toeclipse.platform.text?
> Sent by:        [hidden email]
> ________________________________
>
>
>
>
>
> On Thu, Nov 9, 2017 at 3:13 PM, Daniel Megert <[hidden email]>
> wrote:
> Here is a very simple and obvious example:
> http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/tree/org.eclipse.ltk.core.refactoring/pom.xml
>
> Indeed, moved content won't be available any more. But I don't get why this
> is more an issue than removing any other file in a Git repo. What makes it a
> possible blocker here?
>
> A Gerrit change is against a repository. If the changed project is moved,
> the Gerrit change won't work anymore (unless it gets fixed, as mentioned in
> my message).
>
> Ok, I'll check Gerrit changes to find those which ones affect the LTK
> bundles. For other changes, a simple rebase would
> work._______________________________________________
> eclipse-dev mailing list
> [hidden email]
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_eclipse-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=2pV_VAHeoEGebjHyZTYr2aG1IsfqIeNOaPDourCUVR4&s=aYZmU4OZdkvmSvlNSnEMNX1M3JuKtMWmyeeCbMH5rfw&e=
>
>
>
> _______________________________________________
> eclipse-dev mailing list
> [hidden email]
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/eclipse-dev



--
Eclipse Platform project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: [hidden email], Web: http://www.vogella.com
_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: [eclipse-dev] Moving JDT's LTKbundlestoeclipse.platform.text?

Daniel Megert
In reply to this post by Daniel Megert
I never talk about Gerrit links ;-) Look at it again.

Dani



From:        akurtakov <[hidden email]>
To:        "General development mailing list of the Eclipse project." <[hidden email]>
Date:        09.11.2017 16:23
Subject:        Re: [eclipse-dev] [jdt-dev] Moving JDT's LTK        bundlestoeclipse.platform.text?
Sent by:        [hidden email]






On Thu, Nov 9, 2017 at 4:29 PM, Daniel Megert <daniel_megert@...> wrote:
> Indeed, moved content won't be available any more. But I don't get why this is more an issue than removing any other file in a Git repo. What makes it a possible blocker here?

Because it affects tons of files. It would be good to have a redirect in place.


Dani, are you speaking for open Gerrits or for gerrit links in cgit?
For the former - there aren't that many open gerrits or we are doing really bad job in welcoming people to contribute. Even if there are ( less than 100 gerrits against jdt.ui repo, not sure how many are against ltk bundles) - applying them before or rebasing them would not be that much of effort.
For the later - I am all for preserving history, context and etc. but when this goes to a state where it prevents further improvements and rationalizing of our procedures, codebase, collaboration it becomes more than obvious that we have hit a limit in how much can be preserved in a sane way. Furthermore, personaly I have a special feeling about gerrit links being considered that important now - it always felt like duplication and waste of resources to have BZ and gerrit. BZ is our ultimate tracking tool and bz links will not get broken so gerrit changes will still be accessible through bz links. IMHO such a gerrit redirect would be nice to have but in no way a pre-req for driving some part of the project further.


Dani




From:        
Mickael Istria <mistria@...>
To:        
"Eclipse JDT general developers list." <[hidden email]>
Cc:        
"General development mailing list of the Eclipse project." <[hidden email]>, [hidden email], [hidden email]
Date:        
09.11.2017 15:25
Subject:        
Re: [eclipse-dev] [jdt-dev] Moving JDT's LTK bundles        toeclipse.platform.text?
Sent by:        
[hidden email]






On Thu, Nov 9, 2017 at 3:13 PM, Daniel Megert <
daniel_megert@...> wrote:
Here is a very simple and obvious example:
http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/tree/org.eclipse.ltk.core.refactoring/pom.xml

Indeed, moved content won't be available any more. But I don't get why this is more an issue than removing any other file in a Git repo. What makes it a possible blocker here?

A Gerrit change is against a repository. If the changed project is moved, the Gerrit change won't work anymore (unless it gets fixed, as mentioned in my message).


Ok, I'll check Gerrit changes to find those which ones affect the LTK bundles. For other changes, a simple rebase would work.
_______________________________________________
eclipse-dev mailing list

[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_eclipse-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=2pV_VAHeoEGebjHyZTYr2aG1IsfqIeNOaPDourCUVR4&s=aYZmU4OZdkvmSvlNSnEMNX1M3JuKtMWmyeeCbMH5rfw&e=



_______________________________________________
eclipse-dev mailing list

[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://dev.eclipse.org/mailman/listinfo/eclipse-dev
_______________________________________________
eclipse-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_eclipse-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=ET0bBMuCj8EexSSS2xjj5sNelxeGFryjc6CIViIRpMY&s=embmdmZpddo-fFUh37oNTCcefa61Uuv01z4BxTNCNJM&e=



_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jdt-dev
Reply | Threaded
Open this post in threaded view
|

Re: [eclipse-dev] MovingJDT'sLTKbundlestoeclipse.platform.text?

Daniel Megert
> In the past we used to leave the folder around with short readme file pointing to new location.

That works for people who look at the repo. If they just click on a link they will get a 404 and not the readme ifle.

Dani



From:        akurtakov <[hidden email]>
To:        "General development mailing list of the Eclipse project." <[hidden email]>
Date:        09.11.2017 16:52
Subject:        Re: [eclipse-dev] [jdt-dev] Moving        JDT'sLTKbundlestoeclipse.platform.text?
Sent by:        [hidden email]






On Thu, Nov 9, 2017 at 5:48 PM, Daniel Megert <daniel_megert@...> wrote:
Correct, as I never talked about links to Gerrit.
Well, to quote you "A Gerrit change is against a repository. If the changed project is moved, the Gerrit change won't work anymore (unless it gets fixed, as mentioned in my message)." :P
 
I talk about links from/to http://git.eclipse.org/c/

I undestant what you mean now. In the past we used to leave the folder around with short readme file pointing to new location. That should be enough IMHO.

Alex
 

Dani




From:        
akurtakov <akurtakov@...>
To:        
"General development mailing list of the Eclipse project." <[hidden email]>
Date:        
09.11.2017 16:45
Subject:        
Re: [eclipse-dev] [jdt-dev] Moving JDT's        LTKbundlestoeclipse.platform.text?
Sent by:        
[hidden email]




Hmm, I look at
http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/tree/org.eclipse.ltk.core.refactoring/pom.xmland don't see anything related to Gerrit :). So you would have to tell me exactly what should I look for :)

Alex



On Thu, Nov 9, 2017 at 5:37 PM, Daniel Megert <
daniel_megert@...> wrote:
I never talk about Gerrit links ;-) Look at it again.

Dani




From:        
akurtakov <akurtakov@...>
To:        
"General development mailing list of the Eclipse project." <[hidden email]>
Date:        
09.11.2017 16:23
Subject:        
Re: [eclipse-dev] [jdt-dev] Moving JDT's LTK        bundlestoeclipse.platform.text?
Sent by:        
[hidden email]






On Thu, Nov 9, 2017 at 4:29 PM, Daniel Megert <
daniel_megert@...> wrote:
>
Indeed, moved content won't be available any more. But I don't get why this is more an issue than removing any other file in a Git repo. What makes it a possible blocker here?

Because it affects tons of files. It would be good to have a redirect in place.


Dani, are you speaking for open Gerrits or for gerrit links in cgit?
For the former - there aren't that many open gerrits or we are doing really bad job in welcoming people to contribute. Even if there are ( less than 100 gerrits against jdt.ui repo, not sure how many are against ltk bundles) - applying them before or rebasing them would not be that much of effort.
For the later - I am all for preserving history, context and etc. but when this goes to a state where it prevents further improvements and rationalizing of our procedures, codebase, collaboration it becomes more than obvious that we have hit a limit in how much can be preserved in a sane way. Furthermore, personaly I have a special feeling about gerrit links being considered that important now - it always felt like duplication and waste of resources to have BZ and gerrit. BZ is our ultimate tracking tool and bz links will not get broken so gerrit changes will still be accessible through bz links. IMHO such a gerrit redirect would be nice to have but in no way a pre-req for driving some part of the project further.



Dani




From:        
Mickael Istria <mistria@...>
To:        
"Eclipse JDT general developers list." <[hidden email]>
Cc:        
"General development mailing list of the Eclipse project." <[hidden email]>, [hidden email], [hidden email]
Date:        
09.11.2017 15:25
Subject:        
Re: [eclipse-dev] [jdt-dev] Moving JDT's LTK bundles        toeclipse.platform.text?
Sent by:        
[hidden email]






On Thu, Nov 9, 2017 at 3:13 PM, Daniel Megert <
daniel_megert@...> wrote:
Here is a very simple and obvious example:
http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/tree/org.eclipse.ltk.core.refactoring/pom.xml

Indeed, moved content won't be available any more. But I don't get why this is more an issue than removing any other file in a Git repo. What makes it a possible blocker here?


A Gerrit change is against a repository. If the changed project is moved, the Gerrit change won't work anymore (unless it gets fixed, as mentioned in my message).


Ok, I'll check Gerrit changes to find those which ones affect the LTK bundles. For other changes, a simple rebase would work.
_______________________________________________
eclipse-dev mailing list

[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_eclipse-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=2pV_VAHeoEGebjHyZTYr2aG1IsfqIeNOaPDourCUVR4&s=aYZmU4OZdkvmSvlNSnEMNX1M3JuKtMWmyeeCbMH5rfw&e=



_______________________________________________
eclipse-dev mailing list

[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://dev.eclipse.org/mailman/listinfo/eclipse-dev
_______________________________________________
eclipse-dev mailing list

[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_eclipse-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=ET0bBMuCj8EexSSS2xjj5sNelxeGFryjc6CIViIRpMY&s=embmdmZpddo-fFUh37oNTCcefa61Uuv01z4BxTNCNJM&e=



_______________________________________________
eclipse-dev mailing list

[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://dev.eclipse.org/mailman/listinfo/eclipse-dev
_______________________________________________
eclipse-dev mailing list

[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_eclipse-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=sWEaTHAFEJhEoLrgRhDnc9-ELiOrQinnXdd07iG4_gM&s=Bs03DLFI79cGcCsMqJhbJhBBKMgOsUluFLmo04ZT-es&e=



_______________________________________________
eclipse-dev mailing list

[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://dev.eclipse.org/mailman/listinfo/eclipse-dev
_______________________________________________
eclipse-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_eclipse-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=l9ixtlhXQo88NZBVH6L3YF_8smPI6BcYtoeIvFm9gdM&s=opwWO-WbMoD0UiefW2eIn5l0SKoVRHrxhEUTWDZCXMI&e=



_______________________________________________
jdt-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jdt-dev