Request for Code Review for Bug 503015

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Request for Code Review for Bug 503015

Henrik Hegardt
Hi, made a small fix for a bug where a NPE could happen if a XMLAdapter threw an exception. Found here https://github.com/eclipse/eclipselink.runtime/pull/20

Thanks

_______________________________________________
eclipselink-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
Reply | Threaded
Open this post in threaded view
|

Re: Request for Code Review for Bug 503015

William Dazey
Hello!
Thanks for fixing this bug! I went ahead and updated the bug with comments on your proposed changes.

Also, the process documented on the wiki for opening bugs in bugzilla and submitting patches is documented here: https://wiki.eclipse.org/EclipseLink/Development/Process. However, I do like the thought of using pull requests in lieu of creating patch files. Seeing the bug linked to the pull request is nice too. Do others have thoughts on this? Is there another page somewhere with an updated process for using GitHub?

Thanks,
Will


On Mon, May 29, 2017 at 3:44 PM, Henrik Hegardt <[hidden email]> wrote:
Hi, made a small fix for a bug where a NPE could happen if a XMLAdapter threw an exception. Found here https://github.com/eclipse/eclipselink.runtime/pull/20

Thanks

_______________________________________________
eclipselink-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev


_______________________________________________
eclipselink-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev