Review for 527085

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Review for 527085

William Dazey
I would appreciate a code review for https://bugs.eclipse.org/bugs/show_bug.cgi?id=527085
Its a relatively small change, but I would like to know if anyone has objections with the changes.

_______________________________________________
eclipselink-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
Reply | Threaded
Open this post in threaded view
|

Re: Review for 527085

Bo Liu

William, sorry I'm the one jumping out to reject this change, add the git.hash into the version string is not acceptable. for example as the consequence of your change, we would attempt to upload such version of eclipselink bits to nexus:

2.7.1-$(git.hash}-SNAPSHOT

2.7.1-${git.hash}-RC1

Liu Bo


On 11/10/17 7:12, William Dazey wrote:
I would appreciate a code review for https://bugs.eclipse.org/bugs/show_bug.cgi?id=527085
Its a relatively small change, but I would like to know if anyone has objections with the changes.


_______________________________________________
eclipselink-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_eclipselink-2Ddev&d=DwICAg&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=XWSWwV04cbSI7ylGAvY6jseEOAHf64cXl73jrzI_zxs&m=C7C2C2IeVTUnuyWJI3qD9-Z5ogCN-UvZdGpS0egTd2U&s=fe5jAkx7KsuPzncUsuymIh_NTYjqdJIF0X2cG6BTkM8&e=


_______________________________________________
eclipselink-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
Reply | Threaded
Open this post in threaded view
|

Re: Review for 527085

William Dazey
Thanks for taking a look Bo. I did make the change so that SNAPSHOTS included more qualifying information related to the source level it's built on. The issue I am looking at with the maven version for EclipseLink right now is integrating with with a continuous delivery model. Using a maven version like "2.7.1-SNAPSHOT" lacks a precise versioning to trace the binary to the commit. Would it be acceptable that only SNAPSHOTs include this git.hash versioning? Do we upload SNAPSHOTs to nexus currently?

Thanks,
Will

On Thu, Nov 9, 2017 at 8:29 PM, Bo Liu <[hidden email]> wrote:

William, sorry I'm the one jumping out to reject this change, add the git.hash into the version string is not acceptable. for example as the consequence of your change, we would attempt to upload such version of eclipselink bits to nexus:

2.7.1-$(git.hash}-SNAPSHOT

2.7.1-${git.hash}-RC1

Liu Bo


On 11/10/17 7:12, William Dazey wrote:
I would appreciate a code review for https://bugs.eclipse.org/bugs/show_bug.cgi?id=527085
Its a relatively small change, but I would like to know if anyone has objections with the changes.


_______________________________________________
eclipselink-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_eclipselink-2Ddev&d=DwICAg&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=XWSWwV04cbSI7ylGAvY6jseEOAHf64cXl73jrzI_zxs&m=C7C2C2IeVTUnuyWJI3qD9-Z5ogCN-UvZdGpS0egTd2U&s=fe5jAkx7KsuPzncUsuymIh_NTYjqdJIF0X2cG6BTkM8&e=


_______________________________________________
eclipselink-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev


_______________________________________________
eclipselink-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
Reply | Threaded
Open this post in threaded view
|

Re: Review for 527085

Bo Liu

we are continuously uploading/updating SNAPSHOT to nexus. 2.7.1-SNAPSHOT is how we make it a SNAPSHOT, 2.7.1-${git.hash}-SNAPSHOT doesn't like a SNAPSHOT or even a legal maven version of my understanding.

Liu Bo


On 11/10/17 23:51, William Dazey wrote:
Thanks for taking a look Bo. I did make the change so that SNAPSHOTS included more qualifying information related to the source level it's built on. The issue I am looking at with the maven version for EclipseLink right now is integrating with with a continuous delivery model. Using a maven version like "2.7.1-SNAPSHOT" lacks a precise versioning to trace the binary to the commit. Would it be acceptable that only SNAPSHOTs include this git.hash versioning? Do we upload SNAPSHOTs to nexus currently?

Thanks,
Will

On Thu, Nov 9, 2017 at 8:29 PM, Bo Liu <[hidden email]> wrote:

William, sorry I'm the one jumping out to reject this change, add the git.hash into the version string is not acceptable. for example as the consequence of your change, we would attempt to upload such version of eclipselink bits to nexus:

2.7.1-$(git.hash}-SNAPSHOT

2.7.1-${git.hash}-RC1

Liu Bo


On 11/10/17 7:12, William Dazey wrote:
I would appreciate a code review for https://bugs.eclipse.org/bugs/show_bug.cgi?id=527085
Its a relatively small change, but I would like to know if anyone has objections with the changes.


_______________________________________________
eclipselink-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_eclipselink-2Ddev&d=DwICAg&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=XWSWwV04cbSI7ylGAvY6jseEOAHf64cXl73jrzI_zxs&m=C7C2C2IeVTUnuyWJI3qD9-Z5ogCN-UvZdGpS0egTd2U&s=fe5jAkx7KsuPzncUsuymIh_NTYjqdJIF0X2cG6BTkM8&e=


_______________________________________________
eclipselink-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev



_______________________________________________
eclipselink-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_eclipselink-2Ddev&d=DwICAg&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=XWSWwV04cbSI7ylGAvY6jseEOAHf64cXl73jrzI_zxs&m=IDVTHKQh7iWeZvKzzHTkp55E3Uh9qQBUyNLipxoc26U&s=2O0a1tgYn3VGocjst3mXr3HcCUx3Q1KNSzN_118202M&e=


_______________________________________________
eclipselink-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev