Quantcast

Variables in UserLibrary

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Variables in UserLibrary

Matthew Conway
I've implemented the ability to use Classpath Variables in the
definition of a User Library, but there are 2 minor issues which I'd
like to resolve before submitting a patch, so hopefully someone here can
help.
Both issues have to deal with the preference page - the underlying
functionality works (dare I say it :) flawlessly.

Firstly, I reused the NewVariableEntryDialog class for creating the
variable.  It has a button "Configure...", which normally takes one to
the classpath variable preference page.  This is a problem since I'm in
a dialog that was created from the User Library preference page.  Right
now I just have it disabled, but it would be nice if I had an easy way
to pop up the same preference page in a dialog.

Secondly, and more of a concern, my
UserLibraryContainer.getClasspathEntries() resolves the variables before
returning the result so that things work smoothly with the java build
path (by spec, CPE_CONTAINER cannot return CPE_VARIABLEs).  When I first
define a user library, the ClasspathContainer is of type
CPUserLibraryElement.UpdatedClasspathContainer, and so the preference
page sees the variable nature of the classpath entries because this
class does not resolve variables (which is against spec but...).  
However if I have restarted eclipse since I defined my user library,
then the type of the user library is UserLibraryContainer, and thus the
preference page no longer sees the variable nature.  Any ideas on the
best way to resolve this?

If none of this makes sense, I could always submit the patch to help
clear things up.

Thanks,

Matt

_______________________________________________
eclipse-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Variables in UserLibrary

portal on behalf of Martin Aeschlimann

Hi Matt,
best is if you open a bug against jdt.core or jdt.ui and we can discuss things in there (add me as CC). The first problem is not so difficult, you can create a PreferenceDialog and add just one page. The second one looks more like a hack to me, some discussion is required there.

Martin




Matt Conway <[hidden email]>
Sent by: [hidden email]

27.04.2005 17:08

Please respond to
"General development mailing list of the Eclipse project." <[hidden email]>

To
[hidden email]
cc
Subject
[eclipse-dev] Variables in UserLibrary





I've implemented the ability to use Classpath Variables in the
definition of a User Library, but there are 2 minor issues which I'd
like to resolve before submitting a patch, so hopefully someone here can
help.
Both issues have to deal with the preference page - the underlying
functionality works (dare I say it :) flawlessly.

Firstly, I reused the NewVariableEntryDialog class for creating the
variable.  It has a button "Configure...", which normally takes one to
the classpath variable preference page.  This is a problem since I'm in
a dialog that was created from the User Library preference page.  Right
now I just have it disabled, but it would be nice if I had an easy way
to pop up the same preference page in a dialog.

Secondly, and more of a concern, my
UserLibraryContainer.getClasspathEntries() resolves the variables before
returning the result so that things work smoothly with the java build
path (by spec, CPE_CONTAINER cannot return CPE_VARIABLEs).  When I first
define a user library, the ClasspathContainer is of type
CPUserLibraryElement.UpdatedClasspathContainer, and so the preference
page sees the variable nature of the classpath entries because this
class does not resolve variables (which is against spec but...).  
However if I have restarted eclipse since I defined my user library,
then the type of the user library is UserLibraryContainer, and thus the
preference page no longer sees the variable nature.  Any ideas on the
best way to resolve this?

If none of this makes sense, I could always submit the patch to help
clear things up.

Thanks,

Matt

_______________________________________________
eclipse-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-dev


_______________________________________________
eclipse-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Variables in UserLibrary

Matthew Conway
Martin Aeschlimann wrote:

>
> Hi Matt,
> best is if you open a bug against jdt.core or jdt.ui and we can
> discuss things in there (add me as CC). The first problem is not so
> difficult, you can create a PreferenceDialog and add just one page.
> The second one looks more like a hack to me, some discussion is
> required there.


Done, see https://bugs.eclipse.org/bugs/show_bug.cgi?id=93061

Matt


_______________________________________________
eclipse-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-dev
Loading...